[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-05 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/20724
  
Thanks @yogeshg and @WeichenXu123 !  I verified the new test fails without 
the wrapper fix.
LGTM
Merging with master

I won't bother backporting this since it's a small issue.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20724
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87923/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20724
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20724
  
**[Test build #87923 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87923/testReport)**
 for PR 20724 at commit 
[`07e1829`](https://github.com/apache/spark/commit/07e18299c83d0874f7b5301d0eb80746ab01).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20724
  
**[Test build #87923 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87923/testReport)**
 for PR 20724 at commit 
[`07e1829`](https://github.com/apache/spark/commit/07e18299c83d0874f7b5301d0eb80746ab01).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20724
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20724
  
**[Test build #87920 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87920/testReport)**
 for PR 20724 at commit 
[`d36c1a1`](https://github.com/apache/spark/commit/d36c1a10cd318d9ddeb2717737248c974a2349f1).
 * This patch **fails Python style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20724
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87920/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20724
  
**[Test build #87920 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87920/testReport)**
 for PR 20724 at commit 
[`d36c1a1`](https://github.com/apache/spark/commit/d36c1a10cd318d9ddeb2717737248c974a2349f1).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread jkbradley
Github user jkbradley commented on the issue:

https://github.com/apache/spark/pull/20724
  
add to whitelist


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20724
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20724: [SPARK-18630][PYTHON][ML] Move del method from JavaParam...

2018-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20724
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org