[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21133 Since the SparkR failure is not related to this PR, I merge it to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90060/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #90060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90060/testReport)** for PR 21133 at commit [`aab21a7`](https://github.com/apache/spark/commit/aab21a77bf031b131c8920d1ed2eebd63d4775e5). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2815/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #90060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90060/testReport)** for PR 21133 at commit [`aab21a7`](https://github.com/apache/spark/commit/aab21a77bf031b131c8920d1ed2eebd63d4775e5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21133 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21133 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21133 Above is my major comment https://github.com/apache/spark/pull/21133#discussion_r185030942 cc @juliuszsompolski @cloud-fan Please see whether it makes sense. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21133 @juliuszsompolski I am not sure. This is actually not a performance improvement (strictly speaking that would mean changing an algorithm/code block in order to perform better). Here we are just removing a useless statement which has been wrongly there for legacy reasons. Moreover it is also quite hard to get the benchmark data, since I have not been able to see the query finish without the fix... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user juliuszsompolski commented on the issue: https://github.com/apache/spark/pull/21133 Maybe we could add the former test as a benchmark to `AggregateBenchmark`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89966/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #89966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89966/testReport)** for PR 21133 at commit [`d47d9bd`](https://github.com/apache/spark/commit/d47d9bdf564909a6fc8d3bd67cf696b7c1cf0d4b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2743/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #89966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89966/testReport)** for PR 21133 at commit [`d47d9bd`](https://github.com/apache/spark/commit/d47d9bdf564909a6fc8d3bd67cf696b7c1cf0d4b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21133 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89921/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #89921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89921/testReport)** for PR 21133 at commit [`2fa8da7`](https://github.com/apache/spark/commit/2fa8da744b1726284577deca6c70d184cdae3579). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2715/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #89921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89921/testReport)** for PR 21133 at commit [`2fa8da7`](https://github.com/apache/spark/commit/2fa8da744b1726284577deca6c70d184cdae3579). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89742/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #89742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89742/testReport)** for PR 21133 at commit [`0ac3b4f`](https://github.com/apache/spark/commit/0ac3b4f1ffe05f51abfb58810c385a4daae016c9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21133 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2601/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21133: [SPARK-24013][SQL] Remove unneeded compress in Approxima...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21133 **[Test build #89742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89742/testReport)** for PR 21133 at commit [`0ac3b4f`](https://github.com/apache/spark/commit/0ac3b4f1ffe05f51abfb58810c385a4daae016c9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
