[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 Merging this to master and branch-2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90468/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90468/testReport)** for PR 21278 at commit [`2598313`](https://github.com/apache/spark/commit/25983134159bc4e279ab33a1af0e57cc264f1d3c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3109/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90468/testReport)** for PR 21278 at commit [`2598313`](https://github.com/apache/spark/commit/25983134159bc4e279ab33a1af0e57cc264f1d3c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90439/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90439/testReport)** for PR 21278 at commit [`04c3a2d`](https://github.com/apache/spark/commit/04c3a2d864d980e10bc55518d86e6307b637c6c2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3094/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90439/testReport)** for PR 21278 at commit [`04c3a2d`](https://github.com/apache/spark/commit/04c3a2d864d980e10bc55518d86e6307b637c6c2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21278 nice I like it... they also say ``` When specifying a minimum Java version please use the official version names, which are (confusingly) 1.1 1.2 1.3 1.4 5.0 6 7 8 9 10 and supposedly will in 2018 move to a year.month scheme such as â18.9â. ``` so it might still break in the future though.. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21278 it fails with ``` Quitting from lines 65-67 (sparkr-vignettes.Rmd) Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics: Java version check failed. Please make sure Java is installed and set JAVA_HOME to point to the installation directory. Execution halted ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90425/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90425/testReport)** for PR 21278 at commit [`a0e9b02`](https://github.com/apache/spark/commit/a0e9b02e85a9d587f52ceaabacd382b3ede55036). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3083/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 Looking at http://r-pkgs.had.co.nz/description.html - `... the SystemRequirements field. But this is just a plain text field and is not automatically checked.` I think using `== 8` is probably fine. I also added code to parse this and check equality -- that way if we only support Java 9 in the future we only need to change the `DESCRIPTION` file --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90425/testReport)** for PR 21278 at commit [`a0e9b02`](https://github.com/apache/spark/commit/a0e9b02e85a9d587f52ceaabacd382b3ede55036). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21278 I see yes, maybe grep for java version --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90397/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90397 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90397/testReport)** for PR 21278 at commit [`b4e1039`](https://github.com/apache/spark/commit/b4e10397d890a90a9314dbe4ceef3986c7e0f698). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 Ah I know the problem with the vignettes - if you have _JAVA_OPTIONS set then the line numbers change. i.e. the output looks like ``` shivaram@localhost ~ » export _JAVA_OPTIONS="-XX:-UsePerfData" shivaram@localhost ~ » java -version Picked up _JAVA_OPTIONS: -XX:-UsePerfData java version "1.8.0_92" ``` We need to find the line with 'java version' in it. I'll fix this in the morning --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21278 ``` Quitting from lines 65-67 (sparkr-vignettes.Rmd) Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics: Java version check failed Execution halted ``` hmm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90399/testReport)** for PR 21278 at commit [`7d1894c`](https://github.com/apache/spark/commit/7d1894c2b808dcef62e79f539e44d005ed00becc). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90399/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3065/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21278 yea, I don't think Spark builds on Java 9 (at least from what I've seen) I see the package is gone from CRAN so the test results are brief but maybe related to https://cran.r-project.org/web/checks/check_results_SparkR.html ``` Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics: java.lang.IllegalArgumentException at org.apache.xbean.asm5.ClassReader.(Unknown Source) ``` https://issues.apache.org/jira/browse/SPARK-24201 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90399/testReport)** for PR 21278 at commit [`7d1894c`](https://github.com/apache/spark/commit/7d1894c2b808dcef62e79f539e44d005ed00becc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 Ah got it - Thanks @HyukjinKwon . I'll check if `== 1.8` is supported by R syntax @felixcheung I moved the logic into a `checkJavaVersion` function now. Let me know if this looks better. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21278 (I think Spark itself doesn't properly support Java 9 yet if I haven't missed a discussion or thread) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 Thats a fair question -- I initially created a script was to handle Windows calls but I think we can do some of the split stuff inside R. Let me try that out. Regarding Java 9, do you know why tests fail ? (Is this R specific ?) Reading the documentation, I am not sure we can set it exactly to just be Java 8 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21278 also I think test fails on Java 9 - is there a way to exclude - doc sounds like it's a minimal version --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21278 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3063/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21278 **[Test build #90397 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90397/testReport)** for PR 21278 at commit [`b4e1039`](https://github.com/apache/spark/commit/b4e10397d890a90a9314dbe4ceef3986c7e0f698). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 The need for both the Requirements field and the runtime check is documented at https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Writing-portable-packages (Search for `Make sure that any version requirement for Java code` in that page) cc @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
