[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-08-20 Thread koertkuipers
Github user koertkuipers commented on the issue:

https://github.com/apache/spark/pull/21345
  
we are testing spark 2.4 internally and had some unit tests break because 
of this change i believe.

i am not suggesting this should be changed or undone, just wanted to point 
out that it might have minor implications for people upgrading. so this is just 
an FYI.

it seems that our unit tests for logic that uses flatMapGroupsWithState 
with GroupStateTimeout.ProcessingTimeTimeout now will hang if 
query.processAllAvailable() is called. so i am looking for an alternative way 
to test now that does not involve usage of processAllAvailable.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-18 Thread zsxwing
Github user zsxwing commented on the issue:

https://github.com/apache/spark/pull/21345
  
LGTM again. Merging to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread tdas
Github user tdas commented on the issue:

https://github.com/apache/spark/pull/21345
  
@zsxwing can you take another look?



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90742/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21345
  
**[Test build #90742 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90742/testReport)**
 for PR 21345 at commit 
[`a4ed676`](https://github.com/apache/spark/commit/a4ed676361c3daedb5c6c0465165c7a980cfd056).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3304/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-17 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21345
  
**[Test build #90742 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90742/testReport)**
 for PR 21345 at commit 
[`a4ed676`](https://github.com/apache/spark/commit/a4ed676361c3daedb5c6c0465165c7a980cfd056).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90702/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21345
  
**[Test build #90702 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90702/testReport)**
 for PR 21345 at commit 
[`712d9c0`](https://github.com/apache/spark/commit/712d9c068456246be1205b2889d5e6101303f2a2).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3276/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21345
  
**[Test build #90702 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90702/testReport)**
 for PR 21345 at commit 
[`712d9c0`](https://github.com/apache/spark/commit/712d9c068456246be1205b2889d5e6101303f2a2).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90691/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21345
  
**[Test build #90691 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90691/testReport)**
 for PR 21345 at commit 
[`e243133`](https://github.com/apache/spark/commit/e24313341a91cebb4411eb2c804861dd87a7a257).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread zsxwing
Github user zsxwing commented on the issue:

https://github.com/apache/spark/pull/21345
  
LGTM pending tests


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3270/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21345
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21345
  
**[Test build #90691 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90691/testReport)**
 for PR 21345 at commit 
[`e243133`](https://github.com/apache/spark/commit/e24313341a91cebb4411eb2c804861dd87a7a257).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21345: [SPARK-24159] [SS] Enable no-data micro batches for stre...

2018-05-16 Thread tdas
Github user tdas commented on the issue:

https://github.com/apache/spark/pull/21345
  
@zsxwing  can you take a look?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org