subject:"\[GitHub\] spark issue #21889\: \[SPARK\-4502\]\[SQL\] Parquet nested column pruning \- founda..."

[GitHub] spark issue #21889: [SPARK-4502][SQL] Parquet nested column pruning - founda...

2018-08-16 Thread ajacques

Github user ajacques commented on the issue:

https://github.com/apache/spark/pull/21889
  
Thanks for the response all. @mailman If it's really your preference, I 
will create a PR against that branch and close this one. My intention was never 
to take away from your efforts, and I still consider my work here to be just 
minor stylistic tweaks on top of your work. I did this as service to help 
bridge the divide and hopefully alleviate frustrations. But this has been a bit 
frustrating being stuck between two sides of this and changing merge strategies 
often and don't wish to continue being in between like this. 

As such, I will create a PR, but hope it does not dragged out to settle any 
differences in opinions between maintainers and submitters. My goal is to make 
sure this valuable feature gets merged so many can benefit.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21889: [SPARK-4502][SQL] Parquet nested column pruning - founda...

2018-08-16 Thread mallman

Github user mallman commented on the issue:

https://github.com/apache/spark/pull/21889

Essentially, this PR was created to take the management of #21320 out of my
hands, with a view towards facilitating its incorporation into Spark 2.4. It
was my suggestion, one based in frustration. In hindsight, I no longer believe
this strategy is the bestâor most expedientâapproach towards progress.
Indeed, I believe the direction of this PR has become orthogonal to its
motivating goal, becoming a dispute between myself and @HyukjinKwon rather than
a means to move things along.

I believe I can shepherd #21320 in a way that will promote greater
progress. @ajacques, I mean no disrespect, and I thank you for volunteering
your time, patience and effort for the sake of all that are interested in
seeing this patch become a part of Spark. And I apologize for letting you down,
letting everyone down. In my conduct leading up to the creation of this PR I
did not act with the greatest maturity or patience. And I did not act in the
best interests of the community.

No one has spent more time or more effort, taken more responsibility or
exhibited more patience with this 2+ year patch-set-in-the-making than myself.
I respectfully submit it is mine to present and manage, and no one else's.
Insofar as I have expressed otherwise in the past, I admit my errorâone made
in frustrationâand recant in hindsight.

@ajacques, at this point I respectfully assert that managing the patch set
I submitted in #21320 is not your responsibility, nor is it anyone else's but
mine. I ask you to close this PR so that we can resume the review in #21320. As
I stated there, you are welcome to open a PR on
https://github.com/VideoAmp/spark-public/tree/spark-4502-parquet_column_pruning-foundation
to submit the changes you've made for review.

1 2 >

1 - 100 of 161 matches

Mail list logo