[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21928
  
Thank you @felixcheung, @icexelloss and @BryanCutler.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-31 Thread BryanCutler 
Github user BryanCutler commented on the issue:

https://github.com/apache/spark/pull/21928
  
merged to master and branch-2.3, thanks @HyukjinKwon !


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-31 Thread icexelloss 
Github user icexelloss commented on the issue:

https://github.com/apache/spark/pull/21928
  
I see. Yeah sounds good to me.

On Tue, Jul 31, 2018 at 12:30 PM Hyukjin Kwon 
wrote:

> I think we shouldn't change minimum PyArrow version in 2.4.0 and the
> upgrade doesn't require to change it as far as I remember.
>
> We should backport this anyway even if we will upgrade it for 2.4.0. let's
> go ahead.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21928
  
I think we shouldn't change minimum PyArrow version in 2.4.0 and the 
upgrade doesn't require to change it as far as I remember.

We should backport this anyway even if we will upgrade it for 2.4.0. let's 
go ahead.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21928
  
@icexelloss you mean we should change minimum PyArrow version as well?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-31 Thread icexelloss 
Github user icexelloss commented on the issue:

https://github.com/apache/spark/pull/21928
  
@HyukjinKwon arrow 0.10.0 release is around the corner. I think Spark 2.4 
will very likely to ship with 0.10.0 (where I believe this issue has been 
fixed, @BryanCutler can you confirm?)

I am not sure if it's necessary to has this patch just for pyarrow 0.9.0 ...


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/21928
  
yea, it doesn't seem very useful to ping matei on every single PR ;)



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21928
  
Yea.. this also triggered me to send an email to the mailing list - 
http://apache-spark-developers-list.1001551.n3.nabble.com/Review-notification-bot-tc24133.html


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/21928
  
I wonder if we could tune the bot suggestions to more recent 
contributions/contributors?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21928
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21928
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93821/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21928
  
**[Test build #93821 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93821/testReport)**
 for PR 21928 at commit 
[`652afd0`](https://github.com/apache/spark/commit/652afd0e6f156330d8b0dc28ee519605ae32e971).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21928
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21928
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1513/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21928
  
**[Test build #93821 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93821/testReport)**
 for PR 21928 at commit 
[`652afd0`](https://github.com/apache/spark/commit/652afd0e6f156330d8b0dc28ee519605ae32e971).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread holdensmagicalunicorn 
Github user holdensmagicalunicorn commented on the issue:

https://github.com/apache/spark/pull/21928
  
@HyukjinKwon, thanks! I am a bot who has found some folks who might be able 
to help with the review:@gatorsmile, @JoshRosen and @mateiz


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21928: [SPARK-24976][PYTHON] Allow None for Decimal type conver...

2018-07-30 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21928
  
cc @ueshin, @icexelloss and @BryanCutler 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org