[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 I'm going to say let's leave this alone for now then if there isn't consensus. We can easily reopen later if someone wanted to just add the JARs. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/22084 I'm totally on the user's standpoint, compared to ship these slim jars, it would be better to ship the assembly jars, as those jars can be used directly by adding to Spark's runtime. For these slim jars, it will still require additional third-party jars to make it work even if we add to classpath. Shipping these slim jars will also bring in some questions by users as how to leverage those jars. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 There's no policy stating you have to release all code as binary bits; it just seemed coherent to do so. It isn't a behavior change as it doesn't add anything to the jars/ directory, and won't affect how standalone runs. However I'd just as soon drop this if there's any material objection. A few people expressed support however for just shipping the bits as a formality, even if it does nothing. How does that strike you in the end, @jerryshao ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/22084 From user's point, I don't think it is useful compared to pulling from maven repo, the provided jar alone is of no use. But if there's an Apache policy to release all the binaries, then I'm OK with it. I think this is a behavior change, maybe we should target it as 3.0. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94700/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22084 **[Test build #94700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94700/testReport)** for PR 22084 at commit [`10a1a9c`](https://github.com/apache/spark/commit/10a1a9c6009e03fb13983110e560541073cd67b5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22084 **[Test build #94700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94700/testReport)** for PR 22084 at commit [`10a1a9c`](https://github.com/apache/spark/commit/10a1a9c6009e03fb13983110e560541073cd67b5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2144/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 To maybe summarize: what this isn't doing is actually making these external modules available on the classpath for standalone mode. That would be a reasonable goal, as it would make standalone mode work more like vendor distros happen to work, but it's a behavior change, and Matei pointed out that this also means adding a lot of transitive dependencies to the classpath. If we're not doing that, there's not much point in doing anything. Just shipping these external modules' JARs doesn't help standalone mode, and many people would use them by including them in an app (like they do now). Except that, well, it's still odd that there is no binary distribution of the external modules at all in the binary distribution. So my suggestion here was to at least ship the bits for whatever it may be worth. I also think it's reasonable to say there's no point in that. Therefore I'd suggest the change to make here is either this change or none at all. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22084 +1 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22084 This script isn't exercised in the tests anyway, so the result is not meaningful. I manually tested it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22084 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94648/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22084: [SPARK-25026][BUILD] Binary releases should contain some...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22084 **[Test build #94648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94648/testReport)** for PR 22084 at commit [`5b5c4f5`](https://github.com/apache/spark/commit/5b5c4f5bd3d12410da416a3253dad31508e48ce6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
