[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread suryag10 
Github user suryag10 commented on the issue:

https://github.com/apache/spark/pull/22433
  
> Thank you for your first contribution, @suryag10 .
> 
> * Could you file a SPARK JIRA issue since this is a code change?
Sure.
> * Could you update the PR title like the other PRs? e.g. 
`[SPARK-XXX][SQL][K8S] ...`?
Sure.
> 
> And, just out of curious, do we need this change?
> 
> ```shell
> - exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name 
"Thrift JDBC/ODBC Server" "$@"
> + exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name 
"Thrift-JDBC-ODBC-Server" "$@"
> ```

Without the above change, it fails to start the driver pod as well. Spaces, 
"/" are not allowed for the "name" in the kubernetes world.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread dongjoon-hyun 
Github user dongjoon-hyun commented on the issue:

https://github.com/apache/spark/pull/22433
  
Thank you for your first contribution, @suryag10 .
- Could you file a SPARK JIRA issue since this is a code change?
- Could you update the PR title like the other PRs? e.g. 
`[SPARK-XXX][SQL][K8S] ...`?

And, just out of curious, do we need this change?
```bash
- exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name "Thrift 
JDBC/ODBC Server" "$@"
+ exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name 
"Thrift-JDBC-ODBC-Server" "$@"
```


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22433
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3135/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22433
  
Kubernetes integration test status success
URL: 
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3135/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22433
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22433
  
Kubernetes integration test starting
URL: 
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3135/



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22433
  
**[Test build #96105 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96105/testReport)**
 for PR 22433 at commit 
[`3a7fa57`](https://github.com/apache/spark/commit/3a7fa571181e4b0494f2b705fbd07bc61b0ca6ce).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread ifilonenko 
Github user ifilonenko commented on the issue:

https://github.com/apache/spark/pull/22433
  
test this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22433
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org