[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22464 just one PR including 4 commits --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22464 @cloud-fan Shall we have 4 PRs to revert these PRs individually? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22464 @cloud-fan Ok. Let me try it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22464 @viirya Thanks for doing it! To ease the review, can you revert these 4 commits sequentially with `git revert commit-hash`? Thanks! https://github.com/apache/spark/pull/22344 https://github.com/apache/spark/pull/22330 https://github.com/apache/spark/pull/22239 https://github.com/apache/spark/pull/16677 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22464 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96240/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22464 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22464 **[Test build #96240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96240/testReport)** for PR 22464 at commit [`8ee721c`](https://github.com/apache/spark/commit/8ee721c2923ba125e8d00610a7d9d489010022de). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait BaseLimitExec extends UnaryExecNode with CodegenSupport ` * `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec ` * `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22464 Thanks @HyukjinKwon @maropu. I've put it in the PR description. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22464 I just put the link here: https://github.com/apache/spark/pull/16677#issuecomment-422650759 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22464 @viirya, not a big deal but mind leaving few explicit discussion links (in the PRs you pointed out) to the current PR description? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22464 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3232/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22464 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22464 **[Test build #96240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96240/testReport)** for PR 22464 at commit [`8ee721c`](https://github.com/apache/spark/commit/8ee721c2923ba125e8d00610a7d9d489010022de). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22464 cc @cloud-fan @rxin @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
