[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22472 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96278/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22472 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22472 **[Test build #96278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96278/testReport)** for PR 22472 at commit [`17275d6`](https://github.com/apache/spark/commit/17275d64653f0ae8d94e8004eed6bedbbf74d3fc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 @MaxGekk . It's reverted from `master` and `branch-2.4`. Could you close this PR? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 Thank you, @rxin . Then, I'll proceed it . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/22472 im ok either way --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 IIUC, reverting PRs also need other committers' LGTM in general. @rxin , @gatorsmile . If allowed, I can revert this in `master` and `branch-2.4` without explict PRs as @MaxGekk requested. Shall I proceed to revert? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22472 Probably revert itself can be done directly in the master branch or it has to be done in a PR like this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 The reverting PR title is usually `Revert "[SPARK-23173][SQL] rename spark.sql.fromJsonForceNullableSchema"` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22472: [SPARK-23173][SQL] Reverting of spark.sql.fromJsonForceN...
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22472 > Let's not mix the reverting and adding a deprecation note ok. I will revert the last commit from the PR. > Also, SPARK-25384 is about Removing spark.sql.fromJsonForceNullableSchema, not Deprecating at all. I removed the ticket from PR's title. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
