[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-10-09 Thread squito
Github user squito commented on the issue:

https://github.com/apache/spark/pull/22557
  
merged to master


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-10-08 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22557
  
Ping


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-10-02 Thread squito
Github user squito commented on the issue:

https://github.com/apache/spark/pull/22557
  
lgtm

will leave for a day before mergning


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-10-01 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22557
  
> unrelated, but shouldn't EncryptedMessage.transferTo() not keep looping 
if target.write() doesn't accept all the data?

Yes I noticed that too, but separate change. Hopefully I can fix other 
stuff in commons-crypto that would allow more of that code to be cleaned up...


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96720/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96720 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96720/testReport)**
 for PR 22557 at commit 
[`e6e5382`](https://github.com/apache/spark/commit/e6e538282d408b5a87d7fd81e1c2344e41854f5c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96720 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96720/testReport)**
 for PR 22557 at commit 
[`e6e5382`](https://github.com/apache/spark/commit/e6e538282d408b5a87d7fd81e1c2344e41854f5c).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3550/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22557
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96714/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96714 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96714/testReport)**
 for PR 22557 at commit 
[`e6e5382`](https://github.com/apache/spark/commit/e6e538282d408b5a87d7fd81e1c2344e41854f5c).
 * This patch **fails Java style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96714 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96714/testReport)**
 for PR 22557 at commit 
[`e6e5382`](https://github.com/apache/spark/commit/e6e538282d408b5a87d7fd81e1c2344e41854f5c).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3549/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-27 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22557
  
@squito 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96639/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96639 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96639/testReport)**
 for PR 22557 at commit 
[`4606ed9`](https://github.com/apache/spark/commit/4606ed938a6ec9925dd6fdabd6c90a7f0d2fec71).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96637/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96637 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96637/testReport)**
 for PR 22557 at commit 
[`fe3f06b`](https://github.com/apache/spark/commit/fe3f06bbc5db00acf893fd6c4f70f93ba1648d11).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `  trait BaseErrorHandler extends Closeable `
  * `  class ErrorHandlingReadableChannel(`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96639 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96639/testReport)**
 for PR 22557 at commit 
[`4606ed9`](https://github.com/apache/spark/commit/4606ed938a6ec9925dd6fdabd6c90a7f0d2fec71).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3494/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3493/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22557
  
**[Test build #96637 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96637/testReport)**
 for PR 22557 at commit 
[`fe3f06b`](https://github.com/apache/spark/commit/fe3f06bbc5db00acf893fd6c4f70f93ba1648d11).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22557: [SPARK-25535][core] Work around bad error handling in co...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22557
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org