[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-10-01 Thread shahidki31
Github user shahidki31 commented on the issue:

https://github.com/apache/spark/pull/22592
  
Thank you @srowen for merging.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-10-01 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/22592
  
Merged to master


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-10-01 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22592
  
**[Test build #4355 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4355/testReport)**
 for PR 22592 at commit 
[`ef40698`](https://github.com/apache/spark/commit/ef40698e107090d69e06f41194eb68673791b6d8).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-10-01 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22592
  
**[Test build #4355 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4355/testReport)**
 for PR 22592 at commit 
[`ef40698`](https://github.com/apache/spark/commit/ef40698e107090d69e06f41194eb68673791b6d8).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-10-01 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/22592
  
@shahidki31 when changes aren't urgent, we usually leave them open at least 
a few days for comments. No need to ping unless it's been a week or something.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-30 Thread shahidki31
Github user shahidki31 commented on the issue:

https://github.com/apache/spark/pull/22592
  
Thank you @srowen .


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-30 Thread shahidki31
Github user shahidki31 commented on the issue:

https://github.com/apache/spark/pull/22592
  
Thank you for the review @ajbozarth .


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-29 Thread shahidki31
Github user shahidki31 commented on the issue:

https://github.com/apache/spark/pull/22592
  
Thanks @srowen for reviewing.

>  I think it's OK. Do you need to collapse this one table though? It's the 
only thing on the page.

There are 'Running', 'Completed' and 'Failed' tables  in the SQL page. 
Similar to the Jobs page. 
Also, all the pages ( Jobs, stages etc.) supports hiding table, except SQL 
page. So, behavior should be same for SQL page also, right?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22592
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-29 Thread shahidki31
Github user shahidki31 commented on the issue:

https://github.com/apache/spark/pull/22592
  
cc @srowen @dongjoon-hyun 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22592
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22592
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22592: [SPARK-25575][WEBUI][SQL] SQL tab in the spark UI suppor...

2018-09-29 Thread shahidki31
Github user shahidki31 commented on the issue:

https://github.com/apache/spark/pull/22592
  
Jobs and stages page support hiding table. So to make it consistent, SQL 
tab also should behave the same.
![screenshot from 2018-09-30 
00-15-08](https://user-images.githubusercontent.com/23054875/46249377-f828a180-c445-11e8-9f74-80b0c68a3696.png)
![screenshot from 2018-09-30 
00-15-22](https://user-images.githubusercontent.com/23054875/46249381-fbbc2880-c445-11e8-96e7-3f8cc22dd9f0.png)



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org