[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22595 I read the original PR https://github.com/apache/spark/pull/14617, and it is wired that the two columns are hidden in the very beginning. Also the screenshot in PR description doesn't match the code changes. Ping @jerryshao --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22595 CC @jerryshao for https://github.com/apache/spark/pull/14617 where this was added. It looks like the display is on purpose, but can you clarify? I don't think a "show additional columns" box stuck under the title is the right UI but I haven't looked closely at it. We have a different way of managing extra columns in the Jobs/Stage page for example. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 @srowen The checkbox is what I add in this PR to display/hidden the columns which have been hidden always. These columns are on heap memory, off heap memory. If we want to display them in executor page, we have to change the css file and rebuild the spark-core.jar file. Besides, there should be more and more columns being added in future. Ref [SPARK-23206](https://issues.apache.org/jira/browse/SPARK-23206), [SPARK-23206](https://issues.apache.org/jira/browse/SPARK-23206). If all of them are visible all the time, this page won't be brief like this. So we can simply add a checkbox to let user display them on demand and hidden by default. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22595 Not sure about this. It's not clear why the checkbox is there, what columns it controls. I don't perceive the UI as a problem right now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 cc @dongjoon-hyun @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 If this PR could be merged, #22578 could be added as an additional column as well. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/22595 Gently ping @jerryshao @cloud-fan . Do you have a chance to review? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22595: [SPARK-25577][Web UI] Add an on-off switch to display th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22595 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
