[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 @HyukjinKwon Okay. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22619 Let's just file a JIRA @dilipbiswal BTW. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22619 Looks okay - I checked a case one by one but it needs another look. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 @ueshin > Maybe this is related to #22448. Yeah.. Actually @MaxGekk had pointed me to the presence of duplicate code in one of his comment. I was trying to address it in here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 @gatorsmile There should not be any behaviour change. I was thinking that existing test cases should suffice. Basically we used to duplicate the code of TypeCoercion.findTightestCommonType in here. Here i am just reusing the common function. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22619 Maybe this is related to #22448. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22619 Any behavior change? Test cases? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 cc @HyukjinKwon @MaxGekk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96881/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22619 **[Test build #96881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96881/testReport)** for PR 22619 at commit [`d4e0bdb`](https://github.com/apache/spark/commit/d4e0bdb5a06f59ff1df3933cb43804e71cde8259). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22619 **[Test build #96881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96881/testReport)** for PR 22619 at commit [`d4e0bdb`](https://github.com/apache/spark/commit/d4e0bdb5a06f59ff1df3933cb43804e71cde8259). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3644/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
