[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22637 While we're at it, it would be great to fix the typo in the PR title. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96979/testReport)** for PR 22637 at commit [`58de6a3`](https://github.com/apache/spark/commit/58de6a30c19cd5fe6672938bf969f48aaabd0b31). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public abstract class RowBasedKeyValueBatch extends MemoryConsumer implements Closeable ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96979/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96979/testReport)** for PR 22637 at commit [`58de6a3`](https://github.com/apache/spark/commit/58de6a30c19cd5fe6672938bf969f48aaabd0b31). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22637 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96967/testReport)** for PR 22637 at commit [`5d3d0c7`](https://github.com/apache/spark/commit/5d3d0c7b59c46e8c84dbed340a5a75fcdf01c6d3). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96967/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96975/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96975/testReport)** for PR 22637 at commit [`58de6a3`](https://github.com/apache/spark/commit/58de6a30c19cd5fe6672938bf969f48aaabd0b31). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public abstract class RowBasedKeyValueBatch extends MemoryConsumer implements Closeable ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96975/testReport)** for PR 22637 at commit [`58de6a3`](https://github.com/apache/spark/commit/58de6a30c19cd5fe6672938bf969f48aaabd0b31). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96974/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96974/testReport)** for PR 22637 at commit [`004ee44`](https://github.com/apache/spark/commit/004ee44bf3d10a96477a4a7640d087f0a9d77954). * This patch **fails Java style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public abstract class RowBasedKeyValueBatch extends MemoryConsumer implements Closeable ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96974/testReport)** for PR 22637 at commit [`004ee44`](https://github.com/apache/spark/commit/004ee44bf3d10a96477a4a7640d087f0a9d77954). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96972/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96972/testReport)** for PR 22637 at commit [`14d9d1f`](https://github.com/apache/spark/commit/14d9d1ff3d6d48a2ab89c0ed611b5896caa02e11). * This patch **fails Java style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public abstract class RowBasedKeyValueBatch extends MemoryConsumer implements Closeable ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96972/testReport)** for PR 22637 at commit [`14d9d1f`](https://github.com/apache/spark/commit/14d9d1ff3d6d48a2ab89c0ed611b5896caa02e11). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/22637 Valid points. Personally I'm a fan of explicit final, instead of implicit. But that's a matter of taste :-) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96970/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96970 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96970/testReport)** for PR 22637 at commit [`0155b7a`](https://github.com/apache/spark/commit/0155b7ad4905d75970e600338ed677b23650a901). * This patch **fails Java style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public abstract class RowBasedKeyValueBatch extends MemoryConsumer implements Closeable ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96969/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96969/testReport)** for PR 22637 at commit [`5d3d0c7`](https://github.com/apache/spark/commit/5d3d0c7b59c46e8c84dbed340a5a75fcdf01c6d3). * This patch **fails Java style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96970/testReport)** for PR 22637 at commit [`0155b7a`](https://github.com/apache/spark/commit/0155b7ad4905d75970e600338ed677b23650a901). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96969/testReport)** for PR 22637 at commit [`5d3d0c7`](https://github.com/apache/spark/commit/5d3d0c7b59c46e8c84dbed340a5a75fcdf01c6d3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22637 Jenkins test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22637 **[Test build #96967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96967/testReport)** for PR 22637 at commit [`5d3d0c7`](https://github.com/apache/spark/commit/5d3d0c7b59c46e8c84dbed340a5a75fcdf01c6d3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22637 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22637 mind filling PR description please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22637 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22637: [SPARK-25408] Move to mode ideomatic Java8
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22637 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
