[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22696 LGTM Thanks! Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97289/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97289/testReport)** for PR 22696 at commit [`b0dc140`](https://github.com/apache/spark/commit/b0dc140cd125498070143f67abf51204373fa14c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3908/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97289/testReport)** for PR 22696 at commit [`b0dc140`](https://github.com/apache/spark/commit/b0dc140cd125498070143f67abf51204373fa14c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97280/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97280/testReport)** for PR 22696 at commit [`78a1689`](https://github.com/apache/spark/commit/78a1689ecd7854a11ba709853462897d5e0d1a28). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97280/testReport)** for PR 22696 at commit [`78a1689`](https://github.com/apache/spark/commit/78a1689ecd7854a11ba709853462897d5e0d1a28). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3900/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22696 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97276/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97276/testReport)** for PR 22696 at commit [`78a1689`](https://github.com/apache/spark/commit/78a1689ecd7854a11ba709853462897d5e0d1a28). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97276/testReport)** for PR 22696 at commit [`78a1689`](https://github.com/apache/spark/commit/78a1689ecd7854a11ba709853462897d5e0d1a28). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3896/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22696 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97266/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97266/testReport)** for PR 22696 at commit [`78a1689`](https://github.com/apache/spark/commit/78a1689ecd7854a11ba709853462897d5e0d1a28). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97266/testReport)** for PR 22696 at commit [`78a1689`](https://github.com/apache/spark/commit/78a1689ecd7854a11ba709853462897d5e0d1a28). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3889/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22696 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22696 I think we should mention this in migration guide. Although previous behavior is wrong, it might be treated as a "feature" of Spark SQL. We should explicitly let users know this change. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97254/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97254/testReport)** for PR 22696 at commit [`f6bbd38`](https://github.com/apache/spark/commit/f6bbd38cb7b8684688f0d3deef8605a95111443a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97252/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97252/testReport)** for PR 22696 at commit [`f33400d`](https://github.com/apache/spark/commit/f33400d118c120db54e7155f2b03459177b10194). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22696 I added the release-notes label to the JIRA ticket. I am not sure if there is a migration-guide label. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22696 nice catch! Shall we mention this in the migration guide? It is a behavior change (despite the previous was a wrong behavior), so I think warning users might be a good thing. LGTM otherwise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3883/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97254/testReport)** for PR 22696 at commit [`f6bbd38`](https://github.com/apache/spark/commit/f6bbd38cb7b8684688f0d3deef8605a95111443a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22696 cc @hvanhovell @gatorsmile @viirya @mgaido91 @ueshin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3881/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22696 **[Test build #97252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97252/testReport)** for PR 22696 at commit [`f33400d`](https://github.com/apache/spark/commit/f33400d118c120db54e7155f2b03459177b10194). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22696: [SPARK-25708][SQL] HAVING without GROUP BY means global ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22696 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org