[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22759 **[Test build #4459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4459/testReport)** for PR 22759 at commit [`ac138ff`](https://github.com/apache/spark/commit/ac138ff47bbc33a630d4bb598b9435d1dc653a9e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22759 **[Test build #4459 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4459/testReport)** for PR 22759 at commit [`ac138ff`](https://github.com/apache/spark/commit/ac138ff47bbc33a630d4bb598b9435d1dc653a9e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user dima-asana commented on the issue: https://github.com/apache/spark/pull/22759 > @dima-asana can you rebase, and add a simple test case or else find one that does demonstrate the behavior here? done, sorry for the delay --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22759 Ping @dima-asana to rebase or close --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22759 @dima-asana can you rebase, and add a simple test case or else find one that does demonstrate the behavior here? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22759 LGTM Could you do us a favor to add the test cases for ensuring that the generated parquet files have a correct nullability value? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22759 @dima-asana it looks like this was on purpose: https://github.com/apache/spark/commit/2f38378856fb56bdd9be7ccedf56427e81701f4e CC @gatorsmile I agree though, doesn't appear that it's actually forced to be nullable on write. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22759 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22759 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22759: [MINOR][SQL][DOC] Correct parquet nullability documentat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22759 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
