[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-11-01 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22883
  
(Merged to 2.3 also.)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-11-01 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22883
  
Merging to master / 2.4.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98331/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22883
  
**[Test build #98331 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98331/testReport)**
 for PR 22883 at commit 
[`82fef86`](https://github.com/apache/spark/commit/82fef8686f4b71d94b3bfe44ea809b4d88f5fe70).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98329/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22883
  
**[Test build #98329 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98329/testReport)**
 for PR 22883 at commit 
[`178f7c3`](https://github.com/apache/spark/commit/178f7c3bf82f93177fce086037ece6ebf09bb350).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread patrickbrownsync
Github user patrickbrownsync commented on the issue:

https://github.com/apache/spark/pull/22883
  
I would be happy to start thinking about that.

Can you provide more details on what you mean by data loss on write in the 
InMemoryStore?

I now see that the types being inserted have an annotation around which 
fields they are allowed to be indexed by, but I don't have a good idea of how 
you would allow multiple indexes in a collection short of running something 
like SQLite in memory.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22883
  
**[Test build #98331 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98331/testReport)**
 for PR 22883 at commit 
[`82fef86`](https://github.com/apache/spark/commit/82fef8686f4b71d94b3bfe44ea809b4d88f5fe70).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22883
  
**[Test build #98329 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98329/testReport)**
 for PR 22883 at commit 
[`178f7c3`](https://github.com/apache/spark/commit/178f7c3bf82f93177fce086037ece6ebf09bb350).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22883
  
btw I'm well aware that `InMemoryView` is kinda slow on the read side; 
improvements there would be welcome. The main issue is that the write path 
should be as fast as possible, since that can actually cause data loss if you 
have a burst of new events.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-31 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/22883
  
ok to test


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-30 Thread gengliangwang
Github user gengliangwang commented on the issue:

https://github.com/apache/spark/pull/22883
  
Seems reasonable. Ping @vanzin 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22883: [SPARK-25837] [Core] Fix potential slowdown in AppStatus...

2018-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22883
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org