[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22977 right, I mean both this and that should be part of the process "post-release" --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22977 HiveExternalCatalogVersionsSuite ? that's already updated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22977 I think also there is a hive metastore test that downloads spark release jar? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22977 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98596/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22977 **[Test build #98596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98596/testReport)** for PR 22977 at commit [`a035778`](https://github.com/apache/spark/commit/a0357782e75967d309dc5229b3c36a0c295f2956). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22977 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22977 Actually, similar changes were being made at https://github.com/apache/spark/pull/22967 FYI. cc @dbtsai --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22977 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4848/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22977 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22977 I think one major issue is, there is no document about how to update mima with new releases. Anyone knows the detailed process? Seems we need to update `MimaExcludes.scala` with something like `lazy val v30excludes = v24excludes ++ Seq` when cut the new branch, and update `MimaBuild.scala` when the new release is published. And there are 2 remaining issues. 1. the data source v2 changes broke a lot of mima rules, while I expect interfaces marked as "Envolving" should not be tracked by mima. 2. mllib broke a lot of mima rules, seems caused by https://github.com/apache/spark/pull/22921 . @srowen can you take a look? Also cc @JoshRosen @gatorsmile @shaneknapp @vanzin @holdenk @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22977: [BUILD] Bump previousSparkVersion in MimaBuild.scala to ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22977 **[Test build #98596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98596/testReport)** for PR 22977 at commit [`a035778`](https://github.com/apache/spark/commit/a0357782e75967d309dc5229b3c36a0c295f2956). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org