[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 thanks, merging to master/2.4! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99184/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99184/testReport)** for PR 23043 at commit [`03408d3`](https://github.com/apache/spark/commit/03408d3d44a201040fe9996b213c6b923f1c97dc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5283/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99184/testReport)** for PR 23043 at commit [`03408d3`](https://github.com/apache/spark/commit/03408d3d44a201040fe9996b213c6b923f1c97dc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/23043 `org.apache.spark.sql.MathFunctionsSuite.rint` seems failed due to this change. Can you check it? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99155/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99155/testReport)** for PR 23043 at commit [`a07e614`](https://github.com/apache/spark/commit/a07e614466d08453815e81b937003f1f5eba75ac). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5258/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99155/testReport)** for PR 23043 at commit [`a07e614`](https://github.com/apache/spark/commit/a07e614466d08453815e81b937003f1f5eba75ac). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99132/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99132/testReport)** for PR 23043 at commit [`a07e614`](https://github.com/apache/spark/commit/a07e614466d08453815e81b937003f1f5eba75ac). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99132/testReport)** for PR 23043 at commit [`a07e614`](https://github.com/apache/spark/commit/a07e614466d08453815e81b937003f1f5eba75ac). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5239/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99119/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99119/testReport)** for PR 23043 at commit [`a07e614`](https://github.com/apache/spark/commit/a07e614466d08453815e81b937003f1f5eba75ac). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5225/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99119/testReport)** for PR 23043 at commit [`a07e614`](https://github.com/apache/spark/commit/a07e614466d08453815e81b937003f1f5eba75ac). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/23043 Please also update the PR description to reflect latest change. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99089/testReport)** for PR 23043 at commit [`20d56eb`](https://github.com/apache/spark/commit/20d56ebdcf81d04548509a51c38884e3549f38e3). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99089/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99089/testReport)** for PR 23043 at commit [`20d56eb`](https://github.com/apache/spark/commit/20d56ebdcf81d04548509a51c38884e3549f38e3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5202/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 LGTM except one tiny comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...
Github user adoron commented on the issue: https://github.com/apache/spark/pull/23043 @kiszk is there a use case where the preliminary RDD isn't created with UnsafeRows? If not then the data will already be corrected on reading. Anyway, looking at all different implementations of InternalRow.setDouble I found the following places that aren't handled: ``` OnHeapColumnVector.putDouble MutableDouble.update GenericInternalRow.update SpecificInternalRow.setDouble ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
