[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-60535502 Thanks for doing this, but I think this has been superseded by the refreshed golden files from the upgrade to hive 13. Unless I'm wrong can we close this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user adrian-wang closed the pull request at: https://github.com/apache/spark/pull/2821 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-60543318 Sure, I'll close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-60056640 It's true. Picked [a Jenkins build log](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22027/consoleFull) and searched for select from thrift based table: 00:38:20.797 WARN org.apache.spark.sql.hive.execution.HiveQuerySuite: Running query 1/1 with hive. [info] - select from thrift based table It turned out that the Jenkins build generated the missing golden file successfully. I've no idea why though... Anyway, this LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59859591 I'm confused. How can Jenkins be passing if a golden file is missing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59864484 Seems Jenkins can pass without a golden file now. After run the sbt test I found my working dir is no longer clean with a golden file generated. Also, you can see jenkins log, about cleaning this golden file at start. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/2821 [HOTFIX][SQL] missing golden file for SPARK-3807 create golden file for SPARK-3807 You can merge this pull request into a Git repository by running: $ git pull https://github.com/adrian-wang/spark golden Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2821.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2821 commit ef07c0f3e160edcca280961f1caf62d33dcdc0c1 Author: Daoyuan Wang daoyuan.w...@intel.com Date: 2014-10-16T06:33:16Z missing golden file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59320188 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21797/consoleFull) for PR 2821 at commit [`ef07c0f`](https://github.com/apache/spark/commit/ef07c0f3e160edcca280961f1caf62d33dcdc0c1). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59322559 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21797/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59322554 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21797/consoleFull) for PR 2821 at commit [`ef07c0f`](https://github.com/apache/spark/commit/ef07c0f3e160edcca280961f1caf62d33dcdc0c1). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59322715 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59323161 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21799/consoleFull) for PR 2821 at commit [`ef07c0f`](https://github.com/apache/spark/commit/ef07c0f3e160edcca280961f1caf62d33dcdc0c1). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59328172 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21799/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-59328169 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21799/consoleFull) for PR 2821 at commit [`ef07c0f`](https://github.com/apache/spark/commit/ef07c0f3e160edcca280961f1caf62d33dcdc0c1). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
