[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan closed the pull request at: https://github.com/apache/spark/pull/9081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-171489840 makes sense, changing output of leaf node looks easier to reason about, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-171487491 My concern with this is that no-op operators are going to act as blockers when looking for patterns in the query plan. So thinking about it more I'm not sure this is a good idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-171420150 cc @marmbrus too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-171396586 I think this simplfication can be useful, e.g. https://github.com/apache/spark/pull/10630 Do we agree on this approach? If we do, I can update it soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-171395396 @cloud-fan Should we revisit it later? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-157474071 This seems like a good idea, but I'd propose we delay refactoring until after the 1.6 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-157440817 @cloud-fan I am wondering if this will be merged soon? I am not sure if I should fix a couple of self join issues before your merge. Or I should not waste time until you merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148546209 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43809/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148546208 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148546024 [Test build #43809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43809/console) for PR 9081 at commit [`f0a6f22`](https://github.com/apache/spark/commit/f0a6f2207069d901e4a61c7b46f767a6f21b3a5e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148518894 [Test build #43809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43809/consoleFull) for PR 9081 at commit [`f0a6f22`](https://github.com/apache/spark/commit/f0a6f2207069d901e4a61c7b46f767a6f21b3a5e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148517973 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148517954 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148496546 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43803/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148496543 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148496474 [Test build #43803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43803/console) for PR 9081 at commit [`06dd954`](https://github.com/apache/spark/commit/06dd9546d3e7fd8ae7e54802290355923b7f1426). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148488344 [Test build #43803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43803/consoleFull) for PR 9081 at commit [`06dd954`](https://github.com/apache/spark/commit/06dd9546d3e7fd8ae7e54802290355923b7f1426). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148486981 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148487002 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148486747 hi @marmbrus , checked with @yhuai , `OutputFaker` is no longer used, so I removed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148233671 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148233674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43742/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148233570 [Test build #43742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43742/console) for PR 9081 at commit [`ab3ca9b`](https://github.com/apache/spark/commit/ab3ca9ba83fe06c17c33f62aef840b12e4d38c43). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148208323 [Test build #43742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43742/consoleFull) for PR 9081 at commit [`ab3ca9b`](https://github.com/apache/spark/commit/ab3ca9ba83fe06c17c33f62aef840b12e4d38c43). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148206777 Two more things: - `OutputFaker`, I think thats doing the same thing? Do we need both? Is output faker even used anymore? - Should we update PhysicalOperation too? It could also silently collapse this operator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148205770 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-148205806 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9081#discussion_r41930462 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/MultiInstanceRelation.scala --- @@ -1,33 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - *http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.spark.sql.catalyst.analysis - -import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan - -/** - * A trait that should be mixed into query operators where an single instance might appear multiple - * times in a logical query plan. It is invalid to have multiple copies of the same attribute - * produced by distinct operators in a query tree as this breaks the guarantee that expression - * ids, which are used to differentiate attributes, are unique. - * - * During analysis, operators that include this trait may be asked to produce a new version - * of itself with globally unique expression ids. --- End diff -- In-fact much of this could probably be copied to NewOutput. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9081#discussion_r41930249 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -28,6 +28,17 @@ import org.apache.spark.util.MutablePair import org.apache.spark.util.random.PoissonSampler import org.apache.spark.{HashPartitioner, SparkEnv} +@DeveloperApi +case class NewOutput(output: Seq[Attribute], child: SparkPlan) extends UnaryNode { --- End diff -- scaladoc please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9081#discussion_r41930272 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -23,6 +23,25 @@ import org.apache.spark.sql.catalyst.plans._ import org.apache.spark.sql.types._ import org.apache.spark.util.collection.OpenHashSet +case class NewOutput(output: Seq[Attribute], child: LogicalPlan) extends UnaryNode { --- End diff -- Can you add scaladoc to both of these that explains what they are for. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147857302 cc @marmbrus @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147853396 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147853397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43658/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147853049 [Test build #43658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43658/console) for PR 9081 at commit [`9af906a`](https://github.com/apache/spark/commit/9af906a0571e4391224a51a8573851fdee93e466). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147813225 [Test build #43658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43658/consoleFull) for PR 9081 at commit [`9af906a`](https://github.com/apache/spark/commit/9af906a0571e4391224a51a8573851fdee93e466). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147810148 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147810111 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147809772 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147801423 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147801383 [Test build #43653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43653/console) for PR 9081 at commit [`9af906a`](https://github.com/apache/spark/commit/9af906a0571e4391224a51a8573851fdee93e466). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147801425 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43653/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147797711 [Test build #43653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43653/consoleFull) for PR 9081 at commit [`9af906a`](https://github.com/apache/spark/commit/9af906a0571e4391224a51a8573851fdee93e466). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147795939 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147795907 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147647068 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43635/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147647067 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147647003 [Test build #43635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43635/console) for PR 9081 at commit [`c9645bf`](https://github.com/apache/spark/commit/c9645bf7f7d03f8cabb852d3d5e7d09074228b8b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147639157 [Test build #43635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43635/consoleFull) for PR 9081 at commit [`c9645bf`](https://github.com/apache/spark/commit/c9645bf7f7d03f8cabb852d3d5e7d09074228b8b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147636275 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147636242 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147552341 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43591/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147552338 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147552273 [Test build #43591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43591/console) for PR 9081 at commit [`c2708f8`](https://github.com/apache/spark/commit/c2708f8e3015eea1c73df5ec66245c374b830098). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147535882 [Test build #43591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43591/consoleFull) for PR 9081 at commit [`c2708f8`](https://github.com/apache/spark/commit/c2708f8e3015eea1c73df5ec66245c374b830098). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147535338 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9081#issuecomment-147535313 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11072][SQL] simplify self join handling
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9081 [SPARK-11072][SQL] simplify self join handling https://issues.apache.org/jira/browse/SPARK-11072 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark df Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9081.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9081 commit c2708f8e3015eea1c73df5ec66245c374b830098 Author: Wenchen Fan Date: 2015-10-09T22:15:01Z simplify self join handling --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org