[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43724135
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
+
+// If the "c = 1" filter gets pushed down, this query will throw 
an exception which
+// Parquet emits. This is a Parquet issue (PARQUET-389).
+checkAnswer(
+  sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1"),
--- End diff --

I will try yo check this. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43846677
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
+
+// If the "c = 1" filter gets pushed down, this query will throw 
an exception which
+// Parquet emits. This is a Parquet issue (PARQUET-389).
+checkAnswer(
+  sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1"),
--- End diff --

I investigated that. It does not guarantee the order.

This is because of `FileStatusCache` in `HadoopFsRelation` (which 
`ParquetRelation` extends as you know). When `FileStatusCache.listLeafFiles()` 
is called, this returns `Set[FileStatus]` which messes up the order of 
`Array[FileStatus]`.

So, after retrieving the list of leaf files including `_metadata` and 
`_common_metadata`,  this starts to merge (separately if necessary) the `Set`s 
of `_metadata`, `_common_metadata` and part-files in 
`ParquetRelation.mergeSchemasInParallel()`.

I think this can be resolved by using `LinkedHashSet`.

I will open an issue for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43683918
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
+
+// If the "c = 1" filter gets pushed down, this query will throw 
an exception which
+// Parquet emits. This is a Parquet issue (PARQUET-389).
+checkAnswer(
+  sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1"),
--- End diff --

@HyukjinKwon It will be weird if the column ordering of 
`sqlContext.read.parquet(pathOne, pathTwo)` is not deterministic. Can you try 
it out and see if it is the case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43600244
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
+
+// If the "c = 1" filter gets pushed down, this query will throw 
an exception which
+// Parquet emits. This is a Parquet issue (PARQUET-389).
+checkAnswer(
+  sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1"),
--- End diff --

I see. I just wonder if the inconsistent order is another issue. I think 
users might think it is weird if they run the same script with `SELECT *` but 
the column order of the results are different every time they run.

Could I open an issue for this if you think it is an separate issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152452492
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152452422
  
**[Test build #44664 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44664/consoleFull)**
 for PR 9327 at commit 
[`7007c21`](https://github.com/apache/spark/commit/7007c21779537844691d87d71ec8e86e60835860).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152452494
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44664/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152668696
  
Can you guys take a look at 
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/Spark-Master-SBT/3894/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.0,label=spark-test/testReport/junit/org.apache.spark.sql.execution.datasources.parquet/ParquetFilterSuite/SPARK_11103__Filter_applied_on_merged_Parquet_schema_with_new_column_fails/.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152671514
  
Reverted by 
https://github.com/apache/spark/commit/e8ec2a7b01cc86329a6fbafc3d371bdfd79fc1d6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/9327


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152486378
  
This PR doesn't merge cleanly with branch-1.5, manually resolved the 
conflicts while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152479950
  
Thanks! I'm merging this to master and branch-1.5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43487583
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
--- End diff --

Several nits here, but I'm going to merge this one first since 1.5.2rc2 is 
being cut soon.

- Please use `val` instead of `var` here.
- To construct the test DF, the following way is more preferable for better 
readability:

   ```scala
   sqlContext.range(3).select('id as 'c, 'id cast StringType as 'b)
   ```

   or

   ```scala
   sqlContext.range(3).selectExpr("id AS c", "CAST(id AS STRING) AS b")
   ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43488432
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
--- End diff --

 `val` was used by mistake... Thanks for the comments!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152680479
  
I'm fixing the test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on a diff in the pull request:

https://github.com/apache/spark/pull/9327#discussion_r43565237
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
@@ -314,4 +314,24 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
   }
 }
   }
+
+  test("SPARK-11103: Filter applied on merged Parquet schema with new 
column fails") {
+import testImplicits._
+
+withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true",
+  SQLConf.PARQUET_SCHEMA_MERGING_ENABLED.key -> "true") {
+  withTempPath { dir =>
+var pathOne = s"${dir.getCanonicalPath}/table1"
+(1 to 3).map(i => (i, i.toString)).toDF("a", 
"b").write.parquet(pathOne)
+var pathTwo = s"${dir.getCanonicalPath}/table2"
+(1 to 3).map(i => (i, i.toString)).toDF("c", 
"b").write.parquet(pathTwo)
+
+// If the "c = 1" filter gets pushed down, this query will throw 
an exception which
+// Parquet emits. This is a Parquet issue (PARQUET-389).
+checkAnswer(
+  sqlContext.read.parquet(pathOne, pathTwo).filter("c = 1"),
--- End diff --

It will great if we can specify the columns for this kind of cases because 
the ordering of the columns can be changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152676990
  
Can you guys take a look at 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44697/testReport/junit/org.apache.spark.sql.execution.datasources.parquet/ParquetFilterSuite/SPARK_11103__Filter_applied_on_merged_Parquet_schema_with_new_column_fails/?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152680927
  
Actually @yhuai already opened #9387 to fix this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152619957
  
@liancheng that 1.5 cherry-pick picked a unnecessary test. I will fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152622318
  
Problem fixed with 
https://github.com/apache/spark/commit/6b10ea5d5370d6571ea72b5df658faa1db0c6cbe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152098119
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152098099
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152098139
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152098323
  
**[Test build #44578 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44578/consoleFull)**
 for PR 9327 at commit 
[`85dadbc`](https://github.com/apache/spark/commit/85dadbcb458eec1067b6bae838ca930b8d958f4a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152099924
  
@HyukjinKwon Could you please add a test for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152116901
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44578/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152116722
  
**[Test build #44578 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44578/consoleFull)**
 for PR 9327 at commit 
[`85dadbc`](https://github.com/apache/spark/commit/85dadbcb458eec1067b6bae838ca930b8d958f4a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152116900
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152424940
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152432034
  
**[Test build #44664 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44664/consoleFull)**
 for PR 9327 at commit 
[`7007c21`](https://github.com/apache/spark/commit/7007c21779537844691d87d71ec8e86e60835860).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

Github user HyukjinKwon commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152424928
  
@liancheng oh, right. I just added at `ParquetFilterSuite`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152424957
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

GitHub user HyukjinKwon opened a pull request:

https://github.com/apache/spark/pull/9327

[SPARK-11103][SQL] Filter applied on Merged Parquet shema with new column 
fail

When enabling mergedSchema and predicate filter, this fails since Parquet 
filters are pushed down regardless of each schema of the splits (or rather 
files).

This is related with Parquet issue 
(https://issues.apache.org/jira/browse/PARQUET-389).

For now, it just simply disable predicate push down when using merged 
schema in this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark SPARK-11103

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/9327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9327


commit 85dadbcb458eec1067b6bae838ca930b8d958f4a
Author: hyukjinkwon 
Date:   2015-10-28T08:30:15Z

[SPARK-11103][SQL] Disable predicate push down when using merged schema for 
Parquet.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-151768185
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11103][SQL] Filter applied on Merged Pa...

[HyukjinKwon]

Github user HyukjinKwon commented on the pull request:

https://github.com/apache/spark/pull/9327#issuecomment-152054929
  
/cc @liancheng 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org