[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/9335 [SPARK-11376] [SQL] Removes duplicated `mutableRow` field This PR fixes a mistake in the code generated by `GenerateColumnAccessor`. Interestingly, although the code is illegal in Java (the class has two fields with the same name), Janino accepts it happily and accidentally works properly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark spark-11376.fix-generated-code Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9335.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9335 commit 06a56f293bf013f304aac1eee56c2fa3f2bf0f92 Author: Cheng LianDate: 2015-10-28T14:12:07Z Removes duplicated `mutableRow` field --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151863211 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151862392 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151869676 Experimented with the following snippet: ```scala ... evaluator.cook( s"""private String a = null; | |private Integer a = null; | |@Override |public int add(int lhs, int rhs) { | System.out.println(a); | return lhs + rhs; |} """.stripMargin ) ... ``` Janino doesn't complain as long as the duplicated fields are either both null or not referenced. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151863134 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151864568 **[Test build #44530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44530/consoleFull)** for PR 9335 at commit [`06a56f2`](https://github.com/apache/spark/commit/06a56f293bf013f304aac1eee56c2fa3f2bf0f92). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151899948 **[Test build #44530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44530/consoleFull)** for PR 9335 at commit [`06a56f2`](https://github.com/apache/spark/commit/06a56f293bf013f304aac1eee56c2fa3f2bf0f92). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151900161 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151900164 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44530/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-151921912 L158 Should also be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152063640 Thanks for the review, I'm merging this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152056887 **[Test build #44558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44558/consoleFull)** for PR 9335 at commit [`839449a`](https://github.com/apache/spark/commit/839449afd8c4c4d0b5eeeff951b80216b032a682). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152056493 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152056485 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152075829 **[Test build #44558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44558/consoleFull)** for PR 9335 at commit [`839449a`](https://github.com/apache/spark/commit/839449afd8c4c4d0b5eeeff951b80216b032a682). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152075906 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152075907 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44558/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9335#issuecomment-152058496 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11376] [SQL] Removes duplicated `mutabl...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9335 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org