[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159190700 I think this message is complete useless. I'd just remove it rather than spending time bickering about the wording. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159191082 OK, I will close it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user xguo27 closed the pull request at: https://github.com/apache/spark/pull/9603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159083050 I just don't see any value. It's obvious that the scheduler is starting / stopping. I just can't imagine anyone finding this message useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159088257 Beyond that, the message is actually somewhat misleading. The "Stopping" message occurs in `stop()`, which is responsible for stopping the messageScheduler, eventProcessLoop and taskScheduler. When the "Starting" message is logged, at least the eventProcessLoop and taskScheduler will already have been started, so the argument from symmetry for "Starting" because there is a "Stopping" doesn't hold even without considering that "Starting", ...logMessage, ...logMessage, ... isn't symmetrical to logMessage, ...logMessage, "Stopping" unless we can somehow run time both forwards and backwards. There is also the problem that the "Starting" message is only sent from the secondary constructors and not from the primary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159079918 @andrewor14 What is your take on Jacek's comment? I don't think it's a bad idea to make it more consistent with a matching log message. Please let me know. Thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user jaceklaskowski commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-157309968 I don't agree with @andrewor14. It does add a value of being consistent with how Spark informs about its status - if it says "Stopping..." at INFO it should be corresponding "Starting..." at INFO. That was my initial goal. Consistency is the goal and the value here. Why does Spark report about services being stopped at all? What's the rationale? I would change it to DEBUG, but since all the other logs about starting services are at INFO, I'd leave it as is until someone reports it should be done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-157219217 I agree it is trivial, just thought I could quickly add a log statement. If Jacek agrees, I can close those PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-156274315 Meh, I don't really think this is worth doing. It doesn't add any value or fix anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...
Github user xguo27 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9603#discussion_r44728655
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -506,6 +506,7 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
val (sched, ts) = SparkContext.createTaskScheduler(this, master)
_schedulerBackend = sched
_taskScheduler = ts
+logDebug("Starting DAGScheduler")
--- End diff --
Hi Jacek:
My only concern with putting log in DAGScheduler's constructor is that the
logger might not have been initialized when constructor is called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
