[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157300557
  
yes I will.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157295147
  
@HyukjinKwon This PR doesn't merge cleanly with branch-1.6. Would you 
please file another PR to backport this change to branch-1.6? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/9754


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread liancheng
Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157286298
  
Thanks for cleaning this up! Merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157276165
  
I will cc you @liancheng just so that you can easily find :).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157262462
  
**[Test build #46046 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46046/consoleFull)**
 for PR 9754 at commit 
[`dc5ef4f`](https://github.com/apache/spark/commit/dc5ef4f73f76e68a60590d7203f82b3ebecc6fb0).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157262537
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46046/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157262536
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9754#issuecomment-157240093
  
**[Test build #46046 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46046/consoleFull)**
 for PR 9754 at commit 
[`dc5ef4f`](https://github.com/apache/spark/commit/dc5ef4f73f76e68a60590d7203f82b3ebecc6fb0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-11694][FOLLOW-UP] Clean up imports, use...

2015-11-16 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request:

https://github.com/apache/spark/pull/9754

[SPARK-11694][FOLLOW-UP] Clean up imports, use a common function for 
metadata and add a test for FIXED_LEN_BYTE_ARRAY

As discussed https://github.com/apache/spark/pull/9660 
https://github.com/apache/spark/pull/9060, I cleaned up unused imports, added a 
test for fixed-length byte array and used a common function for writing 
metadata for Parquet.

For the test for fixed-length byte array, I have tested and checked the 
encoding types with 
[parquet-tools](https://github.com/Parquet/parquet-mr/tree/master/parquet-tools).


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark SPARK-11694-followup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/9754.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9754


commit dc5ef4f73f76e68a60590d7203f82b3ebecc6fb0
Author: hyukjinkwon 
Date:   2015-11-17T02:03:32Z

[SPARK-11694][FOLLOW-UP] Clean up imports, use a common function for 
metadata and add a test for FIXED_LEN_BYTE_ARRAY




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org