[GitHub] spark pull request: [SPARK-12249][SQL] JDBC not-equality compariso...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10233#issuecomment-163446650 **[Test build #47459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47459/consoleFull)** for PR 10233 at commit [`6cdd5f3`](https://github.com/apache/spark/commit/6cdd5f31f01af4c91f43c6a3fec12d3416dbdaff). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12249][SQL] JDBC not-equality compariso...
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/10233#issuecomment-163446639 Several things to mention. Firstly, I did not add the tests for it because not pushed down filters are not correctly tested. I will add as soon as https://github.com/apache/spark/pull/10221 is merged. Secondly, I just opened this PR without asking if it is really supposed to be supported. This is because I see the test codes intended to check this operator (which is not testing properly) and also I don't think there is no database not supporting this operator as it is a SQL Standard. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12249][SQL] JDBC not-equality compariso...
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/10233 [SPARK-12249][SQL] JDBC not-equality comparison operator not pushed down. https://issues.apache.org/jira/browse/SPARK-12249 Currently `!=` operator is not pushed down correctly. I simply added a case to this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/spark SPARK-12249 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/10233.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10233 commit 6cdd5f31f01af4c91f43c6a3fec12d3416dbdaff Author: hyukjinkwon Date: 2015-12-10T00:23:26Z Add not-equality comparison operator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
