[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[dilipbiswal]

Github user dilipbiswal commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-216352484
  
@yhuai Sure :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[dilipbiswal]

Github user dilipbiswal closed the pull request at:

https://github.com/apache/spark/pull/10428


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-216335269
  
@dilipbiswal I think 
https://github.com/dongjoon-hyun/spark/commit/a7ce473bd0520c71154ed028f295dab64a7485fe
 has fixed the issue. Can you close this PR? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196710771
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196710774
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53169/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196710599
  
**[Test build #53169 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53169/consoleFull)**
 for PR 10428 at commit 
[`7a7a9b6`](https://github.com/apache/spark/commit/7a7a9b64dc767f66c69483bc7a6b61c57ab97098).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196683541
  
**[Test build #53169 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53169/consoleFull)**
 for PR 10428 at commit 
[`7a7a9b6`](https://github.com/apache/spark/commit/7a7a9b64dc767f66c69483bc7a6b61c57ab97098).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196676937
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196676941
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53165/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196676928
  
**[Test build #53165 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53165/consoleFull)**
 for PR 10428 at commit 
[`cda7275`](https://github.com/apache/spark/commit/cda7275c5c0238f55f8d240d044a727da106d643).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196676152
  
**[Test build #53165 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53165/consoleFull)**
 for PR 10428 at commit 
[`cda7275`](https://github.com/apache/spark/commit/cda7275c5c0238f55f8d240d044a727da106d643).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196589925
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53132/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196589923
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196589535
  
**[Test build #53132 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53132/consoleFull)**
 for PR 10428 at commit 
[`60a331d`](https://github.com/apache/spark/commit/60a331d7fd5bea25cd665d853edd59730ee5cc43).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196559271
  
**[Test build #53132 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53132/consoleFull)**
 for PR 10428 at commit 
[`60a331d`](https://github.com/apache/spark/commit/60a331d7fd5bea25cd665d853edd59730ee5cc43).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-196558845
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-194743977
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[jaceklaskowski]

Github user jaceklaskowski commented on a diff in the pull request:

https://github.com/apache/spark/pull/10428#discussion_r55347052
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
@@ -126,6 +144,13 @@ case class Hour(child: Expression) extends 
UnaryExpression with ImplicitCastInpu
   }
 }
 
+/*
+ * Returns the minute componemnt of the string/timestamp/interval
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(timestamp_param) - Returns the minute  componemnt of the 
timestamp value.",
--- End diff --

s/the minute  componemnt/the minute component


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[frreiss]

Github user frreiss commented on a diff in the pull request:

https://github.com/apache/spark/pull/10428#discussion_r55295539
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
@@ -109,7 +121,13 @@ case class DateSub(startDate: Expression, days: 
Expression)
 })
   }
 }
-
+/*
+ * Returns the hour componemnt of the string/timestamp/interval
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(timestamp_param) - Returns the hour componemnt of the 
timestamp value.",
+  extended = "> SELECT _FUNC_('2001-01-02 11:35:55');\n '11'\n" +
--- End diff --

The returned value is an integer, not a string. Other examples in this file 
should be similarly corrected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[frreiss]

Github user frreiss commented on a diff in the pull request:

https://github.com/apache/spark/pull/10428#discussion_r55294135
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
@@ -109,7 +121,13 @@ case class DateSub(startDate: Expression, days: 
Expression)
 })
   }
 }
-
+/*
+ * Returns the hour componemnt of the string/timestamp/interval
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(timestamp_param) - Returns the hour componemnt of the 
timestamp value.",
+  extended = "> SELECT _FUNC_('2001-01-02 11:35:55');\n '11'\n" +
--- End diff --

The example should make it clearer that the hour component here is from the 
24-hour representation of the timestamp in the local time zone.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[frreiss]

Github user frreiss commented on a diff in the pull request:

https://github.com/apache/spark/pull/10428#discussion_r55293751
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
@@ -109,7 +121,13 @@ case class DateSub(startDate: Expression, days: 
Expression)
 })
   }
 }
-
+/*
+ * Returns the hour componemnt of the string/timestamp/interval
--- End diff --

*component


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[frreiss]

Github user frreiss commented on a diff in the pull request:

https://github.com/apache/spark/pull/10428#discussion_r55293782
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
@@ -109,7 +121,13 @@ case class DateSub(startDate: Expression, days: 
Expression)
 })
   }
 }
-
+/*
+ * Returns the hour componemnt of the string/timestamp/interval
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(timestamp_param) - Returns the hour componemnt of the 
timestamp value.",
--- End diff --

*component


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10428#issuecomment-166542909
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

[dilipbiswal]

GitHub user dilipbiswal opened a pull request:

https://github.com/apache/spark/pull/10428

[SPARK-12458][SQL] Add ExpressionDescription to datetime functions

Below are a couple functions for which there are no corresponding entries 
in functionRegistry.
- TimeAdd
- TimeSub

Is there a reason for this ? I have not added the expression description 
for these two function. 
@yhuai Can you please take a look ?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dilipbiswal/spark functiondoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10428


commit 60a331d7fd5bea25cd665d853edd59730ee5cc43
Author: Dilip Biswal 
Date:   2015-12-22T07:23:35Z

[SPARK-12458] Add ExpressionDescription to datetime functions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org