[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[tgravescs]

Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182895149
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/11038


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[tgravescs]

Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182583973
  
Ok, I'll try it again on clean apache build also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[tgravescs]

Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182580830
  
Can you clarify when you see the exception with inspecting element?

Which browser and plugin, etc?  

When I inspect it with firefox I don't see any errors


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182582778
  
Last I checked I was seeing it on Safari, Firefox and Chrome, no plug-ins. 
I'll build master and spin up a Web UI and double check right now though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182599890
  
**[Test build #51059 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51059/consoleFull)**
 for PR 11038 at commit 
[`318c21f`](https://github.com/apache/spark/commit/318c21fe484f436c839f44b3edb351b3b6715df1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182597718
  
Ok so I'm only seeing it in Safari now, and I did a couple searches based 
on only seeing it in Safari and I found a better fix, I'll push the change 
shortly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182599218
  
It seems that when a expected map file is missing Firefox and Chrome just 
ignore it, Safari on the other hand throws a 404 error. Given the map file 
doesn't exist to begin with it makes more sense to remove the reference to it 
than add the map file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182642556
  
**[Test build #51059 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51059/consoleFull)**
 for PR 11038 at commit 
[`318c21f`](https://github.com/apache/spark/commit/318c21fe484f436c839f44b3edb351b3b6715df1).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182642729
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51059/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-182642727
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-181521289
  
@tgravescs since you did a lot of review on the DataTables addition do you 
want to take a look at this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[holdenk]

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-179418027
  
So looking at the code we can't mix and match the old style and new style 
tables on the same page correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-179425258
  
@holdenk not without changing a large amount of css or html. Both styles 
use common table classes in their basic css. This does seem to be one way 
though, only the old tables are affected when both css files are available, so 
we could potentially edit the old tables css to force use of the old style if 
we want to mix and match on the same page on a case by case basis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178948854
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50625/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178948851
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

GitHub user ajbozarth opened a pull request:

https://github.com/apache/spark/pull/11038

[SPARK-13124] [Web UI] Fixed CSS and JS issues caused by addition of JQuery 
DataTables

Made sure the old tables continue to use the old css and the new DataTables 
use the new css. Also added a min.js.map file so the Web Inspector doesn't 
throw errors when on the new DataTables pages.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ajbozarth/spark spark13124

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11038


commit f2475169e38dfa02e1b555e081a9af4077d23826
Author: Alex Bozarth 
Date:   2016-02-02T03:29:43Z

Fixed CSS JS errors from DataTables

commit 75087f13d4034dc0fb95ddfde8582e3bd1e9
Author: Alex Bozarth 
Date:   2016-02-02T18:58:23Z

Added rat excludes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178951294
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178953512
  
@zhuoliu want to take a look since you added the DataTables


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[ajbozarth]

Github user ajbozarth commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178941357
  
For reference here's what the issues look like, I returned them to their 
original look

![css_issue](https://cloud.githubusercontent.com/assets/13952758/12769988/68c0205c-c9d1-11e5-848b-ad9b1ade22e1.png)
https://cloud.githubusercontent.com/assets/13952758/12769989/68d71f82-c9d1-11e5-96ee-ee7a505a6e5f.png;>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[zhuoliu]

Github user zhuoliu commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178984171
  
Tested also for history page. Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178989963
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178989817
  
**[Test build #50630 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50630/consoleFull)**
 for PR 11038 at commit 
[`75087f1`](https://github.com/apache/spark/commit/75087f13d4034dc0fb95ddfde8582e3bd1e9).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178989966
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50630/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13124] [Web UI] Fixed CSS and JS issues...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11038#issuecomment-178956015
  
**[Test build #50630 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50630/consoleFull)**
 for PR 11038 at commit 
[`75087f1`](https://github.com/apache/spark/commit/75087f13d4034dc0fb95ddfde8582e3bd1e9).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org