[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-09 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181774605
  
**[Test build #50964 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50964/consoleFull)**
 for PR 1 at commit 
[`75bafe6`](https://github.com/apache/spark/commit/75bafe6e8937cdd95ac943649c120a7c483e028e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-09 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181800060
  
**[Test build #50964 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50964/consoleFull)**
 for PR 1 at commit 
[`75bafe6`](https://github.com/apache/spark/commit/75bafe6e8937cdd95ac943649c120a7c483e028e).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-09 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181800643
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50964/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-09 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181800638
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-09 Thread srowen 
Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181823866
  
Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-08 Thread holdenk 
Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181537630
  
This looks good to me, and it looks like we synchronize on the same object 
that the deprecated SynchronizedQueue did so it should still be ok for peoples 
code that was written using that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-08 Thread jodersky 
Github user jodersky commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181538552
  
Agreed, I also just compared it with the SynchronizedQueue sources and 
behaviour should be identical. looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-07 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181028045
  
**[Test build #50903 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50903/consoleFull)**
 for PR 1 at commit 
[`5aebf71`](https://github.com/apache/spark/commit/5aebf718fad3ec03459d999f95e9b403e2c20980).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-07 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181039154
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-07 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181039155
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50903/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-07 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1#issuecomment-181039108
  
**[Test build #50903 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50903/consoleFull)**
 for PR 1 at commit 
[`5aebf71`](https://github.com/apache/spark/commit/5aebf718fad3ec03459d999f95e9b403e2c20980).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-07 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/1#discussion_r52118737
  
--- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -66,7 +65,7 @@ class InputStreamsSuite extends TestSuiteBase with 
BeforeAndAfter {
 // Feed data to the server to send to the network receiver
 val clock = ssc.scheduler.clock.asInstanceOf[ManualClock]
 val expectedOutput = input.map(_.toString)
-for (i <- 0 until input.size) {
+for (i <- input.indices) {
--- End diff --

OK, I touched this up in other code I was touching, and then wanted to do 
it everywhere in this file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13170] [STREAMING] Investigate replacin...

2016-02-07 Thread srowen 
GitHub user srowen opened a pull request:

https://github.com/apache/spark/pull/1

[SPARK-13170] [STREAMING] Investigate replacing SynchronizedQueue as it is 
deprecated

Replace SynchronizeQueue with synchronized access to a Queue

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srowen/spark SPARK-13170

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 5aebf718fad3ec03459d999f95e9b403e2c20980
Author: Sean Owen 
Date:   2016-02-07T14:45:44Z

Replace SynchronizeQueue with synchronized access to a Queue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org