[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-184556107 LGTM, we keep the `VirtualColumn` to show a better error message, merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183977537 **[Test build #51275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51275/consoleFull)** for PR 11100 at commit [`1ca66ac`](https://github.com/apache/spark/commit/1ca66acc4d5cd962124942adcb2411d5c8566081). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183977622 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51275/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183977621 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183951330 **[Test build #51273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51273/consoleFull)** for PR 11100 at commit [`1ca66ac`](https://github.com/apache/spark/commit/1ca66acc4d5cd962124942adcb2411d5c8566081). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183957782 **[Test build #51275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51275/consoleFull)** for PR 11100 at commit [`1ca66ac`](https://github.com/apache/spark/commit/1ca66acc4d5cd962124942adcb2411d5c8566081). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183959207 @gatorsmile do we still need `VirtualColumn`? Other than that LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183950225 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183952193 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51273/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183952190 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183958833 Whoops triggered build unnecessarily --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183963109 @hvanhovell Thank you for your reviews! Although we deprecate `GROUPING__ID`, the new `grouping_id()` still requires `VirtualColumn`. I like this change. Users are not allowed to select/query this hidden/secret column now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183929971 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51272/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183929970 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183929278 **[Test build #51273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51273/consoleFull)** for PR 11100 at commit [`1ca66ac`](https://github.com/apache/spark/commit/1ca66acc4d5cd962124942adcb2411d5c8566081). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183928637 @davies As you suggested, the latest commit has the following changes: - Replaced `GROUPING__ID` by `grouping_id()` in all the test cases and move the results into the test cases - Moved all these test cases in `hive/execution/HiveQuerySuite.scala` to `hive/execution/SQLQuerySuite.scala`. - Detect the possible usage errors in the rule `ResolveGroupingAnalytics` and issue an error message if necessary Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183624342 **[Test build #51229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51229/consoleFull)** for PR 11100 at commit [`7631371`](https://github.com/apache/spark/commit/763137103ea5470a5fa9c14d02b4b0c9d1a32ed1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183624395 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51229/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183624394 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11100#issuecomment-183625392
@davies Already deprecated `GROUPING__ID` in the latest commits and also
clean all the test cases.
Also tried to output a better error message when users manually specify
`GROUPING__ID` in the query, but I hit an issue. To compare the column names,
we need to pass `conf` or `resolver` to the function `checkAnalysis`. This will
touch multiple files that call this function. I am not sure if it is worthy for
this purpose. Let me know if you want me to do it. Thanks!
```
def resolver: Resolver = {
if (conf.caseSensitiveAnalysis) {
caseSensitiveResolution
} else {
caseInsensitiveResolution
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183790347 @gatorsmile I think you can check `GROUPING__ID` in ResolveGroupingAnalytics, then raise an error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52838614 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,6 +216,8 @@ class Analyzer( GroupingSets(bitmasks(c), groupByExprs, child, aggregateExpressions) case Aggregate(Seq(r @ Rollup(groupByExprs)), aggregateExpressions, child) => GroupingSets(bitmasks(r), groupByExprs, child, aggregateExpressions) + // Ensure all the expressions have been resolved. + case g: GroupingSets if g.expressions.exists(!_.resolved) => g case x: GroupingSets => --- End diff -- Ok, will do. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52838613
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
createQueryTest("SPARK-8976 Wrong Result for Rollup #1",
"""
- SELECT count(*) AS cnt, key % 5,GROUPING__ID FROM src group by key%5
WITH ROLLUP
--- End diff --
Will do. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52838911
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
createQueryTest("SPARK-8976 Wrong Result for Rollup #1",
"""
- SELECT count(*) AS cnt, key % 5,GROUPING__ID FROM src group by key%5
WITH ROLLUP
--- End diff --
Got it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52838740
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
createQueryTest("SPARK-8976 Wrong Result for Rollup #1",
"""
- SELECT count(*) AS cnt, key % 5,GROUPING__ID FROM src group by key%5
WITH ROLLUP
--- End diff --
Since we already have the results, just copy them as golden files (or copy
them into test cases).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52836225
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
createQueryTest("SPARK-8976 Wrong Result for Rollup #1",
"""
- SELECT count(*) AS cnt, key % 5,GROUPING__ID FROM src group by key%5
WITH ROLLUP
--- End diff --
use `grouping_id()` instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52838687
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -125,7 +125,7 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
createQueryTest("SPARK-8976 Wrong Result for Rollup #1",
"""
- SELECT count(*) AS cnt, key % 5,GROUPING__ID FROM src group by key%5
WITH ROLLUP
--- End diff --
Hive does not have such a function.
```
SPARK-8976 Wrong Result for GroupingSet *** FAILED *** (316 milliseconds)
[info] Failed to generate golden answer for query:
[info] Error: FAILED: SemanticException [Error 10011]: Line 5:8 Invalid
function 'grouping_id'
[info] org.apache.spark.sql.execution.QueryExecutionException: FAILED:
SemanticException [Error 10011]: Line 5:8 Invalid function 'grouping_id'
```
Hive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52836219 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,6 +216,8 @@ class Analyzer( GroupingSets(bitmasks(c), groupByExprs, child, aggregateExpressions) case Aggregate(Seq(r @ Rollup(groupByExprs)), aggregateExpressions, child) => GroupingSets(bitmasks(r), groupByExprs, child, aggregateExpressions) + // Ensure all the expressions have been resolved. + case g: GroupingSets if g.expressions.exists(!_.resolved) => g case x: GroupingSets => --- End diff -- it's more clear if you move the `if` to next case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183421565 @gatorsmile I think the first commit should be enough. Since 2.0 is the best chance to deprecate GROUPING__ID, we should do that BEFORE release 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183423987 Sure, will revert the changes. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183604929 **[Test build #51229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51229/consoleFull)** for PR 11100 at commit [`7631371`](https://github.com/apache/spark/commit/763137103ea5470a5fa9c14d02b4b0c9d1a32ed1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183474523 **[Test build #51197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51197/consoleFull)** for PR 11100 at commit [`ed518f9`](https://github.com/apache/spark/commit/ed518f946f83ff4d769ca3c095bfa25d406e4a3f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183492086 **[Test build #51197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51197/consoleFull)** for PR 11100 at commit [`ed518f9`](https://github.com/apache/spark/commit/ed518f946f83ff4d769ca3c095bfa25d406e4a3f). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183492379 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183492381 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51197/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183194619 **[Test build #51169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51169/consoleFull)** for PR 11100 at commit [`79c11de`](https://github.com/apache/spark/commit/79c11de8954e137e134d3a8645b6936cd625f38e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183195272 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51169/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183195269 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182902581 **[Test build #51100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51100/consoleFull)** for PR 11100 at commit [`e62c3d0`](https://github.com/apache/spark/commit/e62c3d0f908eb219798c958a6af731ce2750fbb8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user aray commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182891207 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182936788 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182935193 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51100/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182935185 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182942953 **[Test build #5 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 11100 at commit [`e62c3d0`](https://github.com/apache/spark/commit/e62c3d0f908eb219798c958a6af731ce2750fbb8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52665152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,14 +216,36 @@ class Analyzer( GroupingSets(bitmasks(c), groupByExprs, child, aggregateExpressions) case Aggregate(Seq(r @ Rollup(groupByExprs)), aggregateExpressions, child) => GroupingSets(bitmasks(r), groupByExprs, child, aggregateExpressions) - case x: GroupingSets => + // Ensure all the expressions have been resolved. + case g: GroupingSets if g.expressions.exists(!_.resolved) => --- End diff -- g.expressions.forall(_.resolved) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183082733 @gatorsmile Thanks for work on this. The secret column name `GROUPING__ID` is only introduced by Hive, unfortunately the implementation is wrong, we don't follow that(corrected it). We can't be compatible with Hive anyway, so I'd like to not support it (it's OK for 2.0), we can have an error message to tell user to use `grouping_id()`. For the other bug, that could be fixed by resolve all the expressions before GroupingSet (one line change). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183082905 @gatorsmile checked that your two tests could pass with these two tiny changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52675759
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -216,14 +216,36 @@ class Analyzer(
GroupingSets(bitmasks(c), groupByExprs, child,
aggregateExpressions)
case Aggregate(Seq(r @ Rollup(groupByExprs)), aggregateExpressions,
child) =>
GroupingSets(bitmasks(r), groupByExprs, child,
aggregateExpressions)
- case x: GroupingSets =>
+ // Ensure all the expressions have been resolved.
+ case g: GroupingSets if g.expressions.exists(!_.resolved) =>
val gid = AttributeReference(VirtualColumn.groupingIdName,
IntegerType, false)()
-
+// If users manually specify grouping__id in the aggregation
expression, resolve it.
+val aggExprs = g.aggregations.map(_.transform {
+ case u: UnresolvedAttribute if resolver(u.name,
VirtualColumn.groupingIdName) => gid
+}.asInstanceOf[NamedExpression])
+if (aggExprs != g.aggregations) {
+ g.copy(aggregations = aggExprs, groupByExprs = g.groupByExprs :+
gid)
+}
+else {
+ g
+}
+ case x: GroupingSets =>
--- End diff --
Add `if g.expressions.forall(_.resolved)` to make sure that all the
expression are all resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183178340 Thank you! @davies @aray Yeah, my first fix is very similar to what you proposed above. Will remember what you said regarding `GROUPING__ID`. After the release of 2.0, I will try to deprecate it and issue an error message. BTW, just tried the code changes and it works well in my local environment. Updated the codes. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-183180286 **[Test build #51169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51169/consoleFull)** for PR 11100 at commit [`79c11de`](https://github.com/apache/spark/commit/79c11de8954e137e134d3a8645b6936cd625f38e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182977344 **[Test build #5 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 11100 at commit [`e62c3d0`](https://github.com/apache/spark/commit/e62c3d0f908eb219798c958a6af731ce2750fbb8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182977784 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182977781 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182699555 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182730042 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51080/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182730037 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182729529 **[Test build #51080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51080/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182755007 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182706278 **[Test build #51080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51080/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182738409 @davies @hvanhovell @aray I just realized you just reviewed a similar PR: https://github.com/apache/spark/pull/10677. Could you also review this one? I just checked the results are still wrong in the latest code. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182740038 **[Test build #51087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51087/consoleFull)** for PR 11100 at commit [`524dfa0`](https://github.com/apache/spark/commit/524dfa072df691c4c218758b14d01817722577b5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182754914 **[Test build #51087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51087/consoleFull)** for PR 11100 at commit [`524dfa0`](https://github.com/apache/spark/commit/524dfa072df691c4c218758b14d01817722577b5). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182755008 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51087/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181443240 **[Test build #50925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50925/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181436922 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181489463 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181489468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50925/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181488905 **[Test build #50925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50925/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180972576 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180974570 **[Test build #50892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50892/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180983425 **[Test build #50892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50892/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180983458 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50892/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180983457 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181154326 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11100#discussion_r52129135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -215,14 +215,31 @@ class Analyzer(
GroupingSets(bitmasks(c), groupByExprs, child,
aggregateExpressions)
case Aggregate(Seq(r @ Rollup(groupByExprs)), aggregateExpressions,
child) =>
GroupingSets(bitmasks(r), groupByExprs, child,
aggregateExpressions)
- case x: GroupingSets =>
+ // Ensure all the expressions have been resolved.
+ case g: GroupingSets if g.expressions.exists(!_.resolved) =>
val gid = AttributeReference(VirtualColumn.groupingIdName,
IntegerType, false)()
-
+// If users manually specify grouping__id in the aggregation
expression, resolve it.
+val aggExprs = g.aggregations.map(_.transform {
+ case u: UnresolvedAttribute if resolver(u.name,
VirtualColumn.groupingIdName) => gid
+}.asInstanceOf[NamedExpression])
+g.copy(aggregations = aggExprs, groupByExprs = g.groupByExprs :+
gid)
--- End diff --
This one has a potential bug. Will fix it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181171507 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50907/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181170981 **[Test build #50907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50907/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181171502 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181154908 cc @yhuai @marmbrus @rxin Could you check if this one is an appropriate fix? After checking the history, I found you are involved the discussion in the original fix of rollup and cube. : ) @liancheng This is blocking the JIRA https://issues.apache.org/jira/browse/SPARK-12720. Will submit a PR after this issue is addressed. Sorry for the delays. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181157197 **[Test build #50907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50907/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181185188 **[Test build #50909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50909/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181198679 **[Test build #50909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50909/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181198729 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50909/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181198728 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181226883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50910/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181226826 **[Test build #50910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50910/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181226882 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181199107 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-181202248 **[Test build #50910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50910/consoleFull)** for PR 11100 at commit [`114e0eb`](https://github.com/apache/spark/commit/114e0eba1fbdf28e359f15bedacb7defa1998be6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180721464 **[Test build #50869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50869/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180813023 **[Test build #50872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50872/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180792097 Test failures are caused by flaky tests. retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180799710 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180811258 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180829601 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50872/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180829600 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180829394 **[Test build #50872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50872/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180728195 **[Test build #50869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50869/consoleFull)** for PR 11100 at commit [`18f4130`](https://github.com/apache/spark/commit/18f413057b57efb3976dd04a0dfb723cdf59faea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-180728420 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
