[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/11422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-29 Thread marmbrus
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190315075
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190097630
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190097638
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52172/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-29 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190096264
  
**[Test build #52172 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52172/consoleFull)**
 for PR 11422 at commit 
[`ecf4b08`](https://github.com/apache/spark/commit/ecf4b087a4a059b1c66cd2deebfd103786b3f41e).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-28 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190064421
  
**[Test build #52172 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52172/consoleFull)**
 for PR 11422 at commit 
[`ecf4b08`](https://github.com/apache/spark/commit/ecf4b087a4a059b1c66cd2deebfd103786b3f41e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190057233
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52162/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190057230
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-28 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190057138
  
**[Test build #52162 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52162/consoleFull)**
 for PR 11422 at commit 
[`9c17ebe`](https://github.com/apache/spark/commit/9c17ebefe58557850f3a6c6bb6232ca7f2cf7753).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-28 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11422#issuecomment-190034692
  
**[Test build #52162 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52162/consoleFull)**
 for PR 11422 at commit 
[`9c17ebe`](https://github.com/apache/spark/commit/9c17ebefe58557850f3a6c6bb6232ca7f2cf7753).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-13544] [SQL] Rewrite/Propagate Constrai...

2016-02-28 Thread gatorsmile
GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/11422

[SPARK-13544] [SQL] Rewrite/Propagate Constraints for Aliases in Aggregate 
and Windows

 What changes were proposed in this pull request?

After analysis by Analyzer, three operators could have alias. They are 
`Project`, `Aggregate` and `Window`. So far, we only rewrite and propagate 
constraints if `Alias` is defined in `Project`. This PR is to resolve this 
issue in `Aggregate` and `Window`.

 How was this patch tested?

Added a test case for `Aggregate` in `ConstraintPropagationSuite`. We do 
not have a DSL for `Window`. It is a little bit tedious to add such a similar 
case for `Windows`. Could we skip it? : )

@marmbrus @sameeragarwal 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark validConstraintsInUnaryNodes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11422


commit 9c17ebefe58557850f3a6c6bb6232ca7f2cf7753
Author: gatorsmile 
Date:   2016-02-29T04:12:52Z

Propagate constraints for Aliases in Aggregate and Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org