[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201979487 LGTM. Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201971431 ping @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201970947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54268/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201970946 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201970895 **[Test build #54268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54268/consoleFull)** for PR 11959 at commit [`db23480`](https://github.com/apache/spark/commit/db23480f37df7f8ec89e53990fc246c9239bda03). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201952198 **[Test build #54268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54268/consoleFull)** for PR 11959 at commit [`db23480`](https://github.com/apache/spark/commit/db23480f37df7f8ec89e53990fc246c9239bda03). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201742748 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54259/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201742745 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201742650 **[Test build #54259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54259/consoleFull)** for PR 11959 at commit [`021e7c7`](https://github.com/apache/spark/commit/021e7c76eb0f8f1eaa726df3abcd73b7c3e69633). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201723273 **[Test build #54259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54259/consoleFull)** for PR 11959 at commit [`021e7c7`](https://github.com/apache/spark/commit/021e7c76eb0f8f1eaa726df3abcd73b7c3e69633). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201718401 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54251/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201718398 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201718160 **[Test build #54251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54251/consoleFull)** for PR 11959 at commit [`0038563`](https://github.com/apache/spark/commit/0038563ccabbf3c3b81d3f2bc7e39b279879a30c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201704676 **[Test build #54251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54251/consoleFull)** for PR 11959 at commit [`0038563`](https://github.com/apache/spark/commit/0038563ccabbf3c3b81d3f2bc7e39b279879a30c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201698964 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54245/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201698961 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201698540 **[Test build #54245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54245/consoleFull)** for PR 11959 at commit [`b0f449d`](https://github.com/apache/spark/commit/b0f449db4a8c614f98bd888b9391936deedff927). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201659511 **[Test build #54245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54245/consoleFull)** for PR 11959 at commit [`b0f449d`](https://github.com/apache/spark/commit/b0f449db4a8c614f98bd888b9391936deedff927). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11959#discussion_r57506942 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -53,12 +54,19 @@ case class CreateDatabase( extends NativeDDLCommand(sql) with Logging case class CreateFunction( +databaseName: Option[String], functionName: String, alias: String, resources: Seq[(String, String)], isTemp: Boolean)(sql: String) extends NativeDDLCommand(sql) with Logging +case class DropFunction( +functionName: String, --- End diff -- Because from Hive DDL [manual](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/ReloadFunction), it doesn't explicitly mention database name parameter for drop function. But from the parser rule, it uses the same parsing rule as create function DDL command. So it should support database name. Let me add it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201370396 Let me submit a PR for parsing `TOK_DESCDATABASE` and `TOK_DROPDATABASE`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11959#discussion_r57459785 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -53,12 +54,19 @@ case class CreateDatabase( extends NativeDDLCommand(sql) with Logging case class CreateFunction( +databaseName: Option[String], functionName: String, alias: String, resources: Seq[(String, String)], isTemp: Boolean)(sql: String) extends NativeDDLCommand(sql) with Logging +case class DropFunction( +functionName: String, --- End diff -- Looks like we also need the optional DB name, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201346907 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201346909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54177/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201346656 **[Test build #54177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54177/consoleFull)** for PR 11959 at commit [`f0c43b9`](https://github.com/apache/spark/commit/f0c43b958015bada05cb925eadd664064d4675ed). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class DropFunction(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201318151 **[Test build #54177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54177/consoleFull)** for PR 11959 at commit [`f0c43b9`](https://github.com/apache/spark/commit/f0c43b958015bada05cb925eadd664064d4675ed). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/11959 [SPARK-14157][SQL] Parse Drop Function DDL command ## What changes were proposed in this pull request? JIRA: https://issues.apache.org/jira/browse/SPARK-14157 We only parse create function command. In order to support native drop function command, we need to parse it too. ## How was this patch tested? Added test into `DDLCommandSuite`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/viirya/spark-1 parse-drop-func Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11959.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11959 commit f0c43b958015bada05cb925eadd664064d4675ed Author: Liang-Chi HsiehDate: 2016-03-25T14:39:28Z Parse Drop Function DDL command. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201317447 cc @yhuai @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org