[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/11975


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/11975#issuecomment-201907401
  
Thanks - merging in master.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/11975#discussion_r57517025
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala 
---
@@ -114,13 +109,52 @@ trait CodegenSupport extends SparkPlan {
   protected def doProduce(ctx: CodegenContext): String
 
   /**
-* Consume the columns generated from current SparkPlan, call it's 
parent.
+* Consume the generated columns or row from current SparkPlan, call 
it's parent's doConsume().
 */
-  final def consume(ctx: CodegenContext, input: Seq[ExprCode], row: String 
= null): String = {
-if (input != null) {
-  assert(input.length == output.length)
+  final def consume(ctx: CodegenContext, outputVars: Seq[ExprCode], row: 
String = null): String = {
+val inputVars =
+  if (row != null) {
--- End diff --

i was hoping we could remove these branches too. I think it'd require 
putting the outputVars and the row into a single class with different 
constructors. Anyway we can do that later.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11975#issuecomment-201722450
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11975#issuecomment-201722451
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54252/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11975#issuecomment-201722389
  
**[Test build #54252 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54252/consoleFull)**
 for PR 11975 at commit 
[`70fcb4e`](https://github.com/apache/spark/commit/70fcb4e7836976947ca5b22b91ff2924d0206cf9).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11975#issuecomment-201707869
  
**[Test build #54252 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54252/consoleFull)**
 for PR 11975 at commit 
[`70fcb4e`](https://github.com/apache/spark/commit/70fcb4e7836976947ca5b22b91ff2924d0206cf9).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/11975#issuecomment-201707808
  
cc @rxin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14175] [SQL] whole stage codegen interf...

[davies]

GitHub user davies opened a pull request:

https://github.com/apache/spark/pull/11975

[SPARK-14175] [SQL] whole stage codegen interface refactor

## What changes were proposed in this pull request?

1. merge consumeChild into consume()
2. always generate code for input variables and UnsafeRow, a plan can use 
eight of them.

## How was this patch tested?

Existing tests.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davies/spark gen_refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11975


commit 5068aaa873dfbe97d846a16ae0ea061788f363b0
Author: Davies Liu 
Date:   2016-03-26T05:30:09Z

codegen interface refactor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org