[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[jliwork]

Github user jliwork commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-214459899
  
Awesome. Thank you! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12316


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-214016276
  
OK thanks - I'm going to merge this. The test coverage is too excessive 
here. I'm going to remove most of the test cases before merging.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-213927486
  
@rxin it being a bit on the esoteric side and setting a precedence are my 
minor objections. I am fine putting this in given the size and impact this has 
on the code base. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-213892774
  
@hvanhovell Can you think of any downsides if we support this? It is a 
little bit esoteric. The main one I can think of is whether this would set a 
precedent in that a lot of people start to submit "compatibility" things for 
esoteric features for different databases.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-212316779
  
**[Test build #2834 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2834/consoleFull)**
 for PR 12316 at commit 
[`e8aefe0`](https://github.com/apache/spark/commit/e8aefe05cce990bb5f2205a0a84dabf7d423e9bd).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-212283550
  
**[Test build #2834 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2834/consoleFull)**
 for PR 12316 at commit 
[`e8aefe0`](https://github.com/apache/spark/commit/e8aefe05cce990bb5f2205a0a84dabf7d423e9bd).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[jliwork]

Github user jliwork commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-212281661
  
@rxin gentle ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[jliwork]

Github user jliwork commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-209606539
  
@rxin Microsoft SQL Server, IBM DB2 and Sybase Adaptive Server support 
them. 

https://msdn.microsoft.com/en-us/library/ms188074.aspx

http://www.ibm.com/support/knowledgecenter/SSEPGG_10.5.0/com.ibm.db2.luw.sql.ref.doc/doc/r746.html?lang=en

http://infocenter.sybase.com/archive/index.jsp?topic=/com.sybase.dc36271_36272_36273_36274_1250/html/refman/refman237.htm



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-209247018
  
Can you summarize the list of database systems that support this syntax?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-209244788
  
I am not nessecarily against this but I find these quite confusing. Why not 
just write `>=` or `<=`?

The PR itself looks pretty solid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[jliwork]

Github user jliwork commented on a diff in the pull request:

https://github.com/apache/spark/pull/12316#discussion_r59323956
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1432,4 +1432,15 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   getMessage()
 assert(e1.startsWith("Path does not exist"))
   }
+
+  test("test !< and !> comparator") {
--- End diff --

Hi @rxin, 
Thanks for your comment! I've removed this test case from DataFrameSuite. 
Please free free to let me know of any other comments or questions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-208677145
  
FYI, MS SQL Server supports these operators: 
https://msdn.microsoft.com/en-us/library/ms188074.aspx 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-208663567
  
Can you trigger the jenkin test? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-208663019
  
No let's not do that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-208662276
  
@rxin Do we need to add these operators to dsl?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/12316#discussion_r59310976
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
@@ -1432,4 +1432,15 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
   getMessage()
 assert(e1.startsWith("Path does not exist"))
   }
+
+  test("test !< and !> comparator") {
--- End diff --

you probably don't need this test case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12316#issuecomment-208660462
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14548][SQL] Support not greater than an...

[jliwork]

GitHub user jliwork opened a pull request:

https://github.com/apache/spark/pull/12316

[SPARK-14548][SQL] Support not greater than and not less than operator in 
Spark SQL

## What changes were proposed in this pull request?

!< means not less than which is equivalent to >=
!> means not greater than which is equivalent to <=

I'd to create a PR to support these two operators. 

## How was this patch tested?

I've added new test cases in: DataFrameSuite, ExpressionParserSuite, 
JDBCSuite, PlanParserSuite, SQLQuerySuite

@dilipbiswal @viirya @gatorsmile 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jliwork/spark SPARK-14548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12316


commit 6792fe59990fcc925eb86bcbcd297f6f57505c8e
Author: jliwork 
Date:   2016-04-12T01:33:50Z

support not greater than and not less than operator in Spark SQL




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org