[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-24 Thread kasjain 
Github user kasjain commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221177377
  
Sure. Let me add the CTAS query in the test suite


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-23 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221064487
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59146/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-23 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221064485
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-23 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221064216
  
**[Test build #59146 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59146/consoleFull)**
 for PR 12356 at commit 
[`5ba453b`](https://github.com/apache/spark/commit/5ba453b790b5bfa0e34ee54193e374d14bd3ee33).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-23 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221047970
  
**[Test build #59146 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59146/consoleFull)**
 for PR 12356 at commit 
[`5ba453b`](https://github.com/apache/spark/commit/5ba453b790b5bfa0e34ee54193e374d14bd3ee33).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-23 Thread marmbrus 
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221046569
  
Is it possible to write unit tests for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-23 Thread marmbrus 
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-221046599
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-22 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-220825875
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-216117008
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57504/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-02 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-216117006
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-02 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-216116911
  
**[Test build #57504 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57504/consoleFull)**
 for PR 12356 at commit 
[`5ba453b`](https://github.com/apache/spark/commit/5ba453b790b5bfa0e34ee54193e374d14bd3ee33).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-01 Thread kasjain 
Github user kasjain commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-216108723
  
Resolved the merge conflicts for easy merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-05-01 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-216108200
  
**[Test build #57504 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57504/consoleFull)**
 for PR 12356 at commit 
[`5ba453b`](https://github.com/apache/spark/commit/5ba453b790b5bfa0e34ee54193e374d14bd3ee33).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-29 Thread rxin 
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-215923995
  
cc @marmbrus 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-22 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-213297299
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56660/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-22 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-213297295
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-22 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-213297061
  
**[Test build #56660 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56660/consoleFull)**
 for PR 12356 at commit 
[`ca9a160`](https://github.com/apache/spark/commit/ca9a1608534afa509bd28390361b3babd052e129).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-22 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-213276919
  
**[Test build #56660 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56660/consoleFull)**
 for PR 12356 at commit 
[`ca9a160`](https://github.com/apache/spark/commit/ca9a1608534afa509bd28390361b3babd052e129).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-22 Thread kasjain 
Github user kasjain commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-213275310
  
Resolved the merge conflicts for easy merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-17 Thread kasjain 
Github user kasjain commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-211176212
  
Can any of the admin verify the above fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-14 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209783945
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55796/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-14 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209783939
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-14 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209783409
  
**[Test build #55796 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55796/consoleFull)**
 for PR 12356 at commit 
[`6bd529c`](https://github.com/apache/spark/commit/6bd529cb8dfc6a2322a45eb7f6f606fcfc764202).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209771838
  
**[Test build #55796 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55796/consoleFull)**
 for PR 12356 at commit 
[`6bd529c`](https://github.com/apache/spark/commit/6bd529cb8dfc6a2322a45eb7f6f606fcfc764202).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread saucam 
Github user saucam commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209762085
  
I think we can eliminate applyFilterIfNeeded method as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread andrewor14 
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209673967
  
@liancheng @yhuai?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209663296
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55741/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209663292
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209663051
  
**[Test build #55741 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55741/consoleFull)**
 for PR 12356 at commit 
[`48a598e`](https://github.com/apache/spark/commit/48a598efe78ef1c9560a6af2d74e98b3bfaa8819).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209642963
  
**[Test build #55741 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55741/consoleFull)**
 for PR 12356 at commit 
[`48a598e`](https://github.com/apache/spark/commit/48a598efe78ef1c9560a6af2d74e98b3bfaa8819).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread andrewor14 
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209642363
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12356#issuecomment-209366092
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14557][SQL] Reading textfile (created t...

2016-04-13 Thread kasjain 
GitHub user kasjain opened a pull request:

https://github.com/apache/spark/pull/12356

[SPARK-14557][SQL] Reading textfile (created though CTAS) doesn't work

## What changes were proposed in this pull request?

These changes fixes the below broken functionality
Reading the CSV table created through CTAS query when the path pathFilter 
is provided.
1) A bug in HadoopFileReader. Resolved by passing the directory instead of
a list of files in case of pathFilter also, since the below code sets the 
path incorrectly otherwise.
 FileInputFormat.setInputPaths(jobConf, Seq[Path](new Path(path)): _*) 

2) Not using the applyFilterIfApplicable since this triggers the filtering 
twice. Once in applyFilterIfApplicable and then again in FileInputFormat. These 
changes will also save multiple filterings in the codePath.

## How was this patch tested?
Integration tests, manual tests


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kasjain/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12356


commit 48a598efe78ef1c9560a6af2d74e98b3bfaa8819
Author: Kashish Jain 
Date:   2016-04-13T10:40:34Z

[SPARK-14557][SQL] Reading textfile (created though CTAS) doesn't work when
pathFilter is enabled.
1) A bug in HadoopFileReader. Resolved by passing the directory instead
of a list of files in case of pathFilter also, since it gets triggerred in
FileInputFormat. This also saves multiple filterings in the codePath.
2) Not using the applyFilterIfApplicable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org