[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12747 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215666590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57322/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215666588 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215666426 **[Test build #57322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57322/consoleFull)** for PR 12747 at commit [`6a6e96a`](https://github.com/apache/spark/commit/6a6e96a10ff7cdbda1c8afb0025af79e4a29ce9f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215651971 **[Test build #57322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57322/consoleFull)** for PR 12747 at commit [`6a6e96a`](https://github.com/apache/spark/commit/6a6e96a10ff7cdbda1c8afb0025af79e4a29ce9f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215651245 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user dding3 commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215609146 @srowen Thanks for your review. I have removed it in ANNGradient. Besides, I checked all subclass of Gradient, looks like there is no duplicate implementation now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215363871 You can also remove the one in `ANNGradient` right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215281057 LGTM . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user dding3 commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215280895 Thanks for your comments. Removed the PR description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14969][MLLib] Remove duplicate implemen...
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12747#issuecomment-215280483 (@dding3 I think maybe you can remove the default lines such as "(Please fill in changes proposed in this fix)".) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
