[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12958#issuecomment-218225663 Trigger clock is an internal details for testing that should not be exposed to users. Also, this isn't really what the output mode is for. Try reading the design doc posted on JIRA: https://issues.apache.org/jira/browse/SPARK-8360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...
Github user agsachin commented on the pull request: https://github.com/apache/spark/pull/12958#issuecomment-217718480 @tdas , @marmbrus any inputs on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...
Github user agsachin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12958#discussion_r62431170
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -25,13 +25,13 @@ import org.apache.hadoop.fs.Path
import org.apache.spark.annotation.Experimental
import org.apache.spark.sql.catalyst.TableIdentifier
-import org.apache.spark.sql.catalyst.analysis.UnresolvedRelation
+import org.apache.spark.sql.catalyst.analysis.{Update, OutputMode, Append,
UnresolvedRelation}
--- End diff --
thanks I have fixed the scala style issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12958#discussion_r62417617
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -25,13 +25,13 @@ import org.apache.hadoop.fs.Path
import org.apache.spark.annotation.Experimental
import org.apache.spark.sql.catalyst.TableIdentifier
-import org.apache.spark.sql.catalyst.analysis.UnresolvedRelation
+import org.apache.spark.sql.catalyst.analysis.{Update, OutputMode, Append,
UnresolvedRelation}
--- End diff --
(I think it will throws an error for style check and should be as below:)
```scala
import org.apache.spark.sql.catalyst.analysis.{Append, OutputMode,
UnresolvedRelation, Update}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15183][Streaming] Adding outputMode to ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12958#issuecomment-217482035 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
