[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50721673 QA results for PR 1669:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17556/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50797594 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50798433 QA tests have started for PR 1669. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17590/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50807633 QA results for PR 1669:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17590/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50643385 I am worried this PR might have broken testing in Maven: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-pre-YARN/228/hadoop.version=2.0.0-mr1-cdh4.1.2,label=centos/testReport/junit/org.apache.spark.sql.hive.execution/HiveTableScanSuite/partition_based_table_scan_with_different_serde/ Can you please investigate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50644241 I am looking at it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50676098 Oh, clever. This isn't actually what I was suggesting but is a better solution :) I forgot that createQueryTest could handle multiple sql statements. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50682859 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50698720 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50699975 Thank you @yhuai, that seems cool. But can you also remove the old golden answer file? It should be unused now. `golden/partition_based_table_scan_with_different_serde-0-8caed2a6e80250a6d38a59388679c298` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50700017 Oh, sorry, I saw that, it renamed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50715127 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50715565 QA tests have started for PR 1669. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17556/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50364539 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50374334 Thanks! I've merged this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50425581 @marmbrus seems this PR is still open. Can you double check if it's merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50425995 Apache mirroring is broken. We've filled a bug with infra. On Jul 28, 2014 6:50 PM, Cheng Hao notificati...@github.com wrote: @marmbrus https://github.com/marmbrus seems this PR is still open. Can you double check if it's merged? â Reply to this email directly or view it on GitHub https://github.com/apache/spark/pull/1439#issuecomment-50425581. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50295934 Thank you @yhuai , @liancheng ,I've updated the code according to your comments, let's see if SparkQA happy with the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50295944 QA tests have started for PR 1439. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17269/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-50299661 QA results for PR 1439:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass HadoopTableReader(brbrFor more information see test ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17269/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/1439 [SPARK-2523] [SQL] Hadoop table scan In HiveTableScan.scala, ObjectInspector was created for all of the partition based records, which probably causes ClassCastException if the object inspector is not identical among table partitions. This is the follow up with: https://github.com/apache/spark/pull/1408 https://github.com/apache/spark/pull/1390 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenghao-intel/spark hadoop_table_scan Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1439 commit 39d6475d8cf357488fd1ec736b4d910f8237fc5b Author: Cheng Hao hao.ch...@intel.com Date: 2014-07-16T07:59:50Z Add HiveDecimal HiveVarchar support in unwrap data commit afc39da00f53f15edb466768c24cdd73ec5bc119 Author: Cheng Hao hao.ch...@intel.com Date: 2014-07-16T08:21:25Z Polish the code commit d66835b420e22f98e10556783102e7dc356e6e6a Author: Cheng Hao hao.ch...@intel.com Date: 2014-07-16T08:24:30Z Fix Bug in TableScan while Paritition SerDe is not compatiable with each other --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1439#issuecomment-49138252 QA tests have started for PR 1439. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16724/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---