[GitHub] spark pull request: [SPARK-2535][SQL] Add StringComparison case to...

2014-07-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/1451


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2535][SQL] Add StringComparison case to...

2014-07-18 Thread marmbrus
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/1451#issuecomment-49481477
  
Thanks for doing this, and even adding tests for my code :)

Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2535][SQL] Add StringComparison case to...

2014-07-16 Thread ueshin
GitHub user ueshin opened a pull request:

https://github.com/apache/spark/pull/1451

[SPARK-2535][SQL] Add StringComparison case to NullPropagation.

`StringComparison` expressions including `null` literal cases could be 
added to `NullPropagation`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ueshin/apache-spark issues/SPARK-2535

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1451


commit 8f9b98439b6e3bf674ae22a6a6a716e27da509f2
Author: Takuya UESHIN ues...@happy-camper.st
Date:   2014-07-15T09:08:13Z

Add StringComparison case to NullPropagation.

commit e99c237f661589792cde6451466d2c44e783cd82
Author: Takuya UESHIN ues...@happy-camper.st
Date:   2014-07-16T10:59:58Z

Add some tests.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2535][SQL] Add StringComparison case to...

2014-07-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1451#issuecomment-49243557
  
QA tests have started for PR 1451. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16752/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2535][SQL] Add StringComparison case to...

2014-07-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1451#issuecomment-49249573
  
QA results for PR 1451:br- This patch PASSES unit tests.br- This patch 
merges cleanlybr- This patch adds no public classesbrbrFor more 
information see test 
ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16752/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---