[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/1490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-51699706 This issue is addressed in #1758 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-51274565 O.K. I take over this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-51072948 Thanks for your back up @JoshRosen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-51114201 Thanks for submitting this PR; it only took a little work for me to pick it up. Do you mind closing this issue, since I'll finish this in #1758? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-50439564 I looked at this (with some confusion). Yes, I agree it would be great to just signal failure using the promise when an error occurs. @sarutak do you think you can do that change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-50459001 Thank you for you comment @JoshRosen , @rxin . Of course I'll try it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-50423106 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-50423489 QA results for PR 1490:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17326/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-50424188 The Jenkins build failed because your code failed the automated Scala style checks (see the [Spark Code Style Guide](https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide)). You can run `sbt/sbt scalastyle` to run these checks locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-50036963 I added a test case to ConnectionManager.scala for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-49955212 I added some tests for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1490#discussion_r15145612
--- Diff:
core/src/main/scala/org/apache/spark/network/MessageChunkHeader.scala ---
@@ -41,6 +42,13 @@ private[spark] class MessageChunkHeader(
putInt(totalSize).
putInt(chunkSize).
putInt(other).
+ put{
--- End diff --
How about
```scala
put(if (hasError) 1.asInstanceOf[Byte] else 0.asInstanceOf[Byte])
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1490#discussion_r15145614
--- Diff:
core/src/main/scala/org/apache/spark/network/MessageChunkHeader.scala ---
@@ -67,13 +75,20 @@ private[spark] object MessageChunkHeader {
val totalSize = buffer.getInt()
val chunkSize = buffer.getInt()
val other = buffer.getInt()
+val hasError = {
--- End diff --
```scala
val hasError = buffer.get() != 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2583] ConnectionManager cannot distingu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1490#issuecomment-49528521 Thanks @rxin I'll try it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
