[GitHub] spark pull request: [SPARK-3485][SQL] Use GenericUDFUtils.Conversi...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2407#issuecomment-56244907 Thanks! I've merged this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3485][SQL] Use GenericUDFUtils.Conversi...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2407#issuecomment-55864941 I add a test case to this file, the current master will fail the case because we missed `Short` in the `primitiveTypes` here. With this new solution, we can get rid of maintaining of `primitiveTypes`, and eliminate potential bugs here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3485][SQL] Use GenericUDFUtils.Conversi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2407#issuecomment-55865221 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20459/consoleFull) for PR 2407 at commit [`15762d2`](https://github.com/apache/spark/commit/15762d2f3835644397d9dbf5ba87bedd9bb91e1c). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3485][SQL] Use GenericUDFUtils.Conversi...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2407#issuecomment-55874010 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20459/consoleFull) for PR 2407 at commit [`15762d2`](https://github.com/apache/spark/commit/15762d2f3835644397d9dbf5ba87bedd9bb91e1c). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3485][SQL] Use GenericUDFUtils.Conversi...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/2407#issuecomment-55985941 +1, LGTM. I think this can go first, as it's simpler and cleaner (maybe fixed some unknown bugs), besides, it blocks the #2344. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3485][SQL] Use GenericUDFUtils.Conversi...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2407#issuecomment-55851964 Thanks for referencing pr 2241 here, while I think this should be reviewed first, and will make 2241 simpler, as well as getting `date` type support into catalyst earlier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
