[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55757044 It happens because in the git diff the script compares the PR branch with master and if PR is not rebased to the tip of master. False reporting will happen. Won't those changes show up as removed lines though? The script that posts these new classes filters in [only added lines](https://github.com/apache/spark/blob/febafefa5aaee3b3eda5e1b45a75bc6d8e7fb13f/dev/run-tests-jenkins#L102). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55759519 Actually, I guess if a class was removed from master but not also removed from the PR fork, then that would show up as an added class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/2404 [SPARK-3540] Add reboot-slaves functionality to the ec2 script Tested on a real cluster. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark ec2-reboot-slaves Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2404 commit 00a2dbd72ca0caba00aa0d838361a23fb381149b Author: Reynold Xin r...@apache.org Date: 2014-09-16T02:22:29Z Allow rebooting slaves. (cherry picked from commit 9aaad3ccc093854c6582ae015d3afb1a9aa14f54) Signed-off-by: Reynold Xin r...@apache.org --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55687301 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20364/consoleFull) for PR 2404 at commit [`00a2dbd`](https://github.com/apache/spark/commit/00a2dbd72ca0caba00aa0d838361a23fb381149b). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55690973 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20364/consoleFull) for PR 2404 at commit [`00a2dbd`](https://github.com/apache/spark/commit/00a2dbd72ca0caba00aa0d838361a23fb381149b). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` class ArrayConstructor extends net.razorvine.pickle.objects.ArrayConstructor ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55691649 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55692669 Merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55692659 @ScrapCodes any idea why random public classes are being reported, even though they have nothing to do with this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55693199 It happens because in the git diff the script compares the PR branch with master and if PR is not rebased to the tip of master. False reporting will happen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3540] Add reboot-slaves functionality t...
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2404#issuecomment-55693512 So I guess it came from the commit, https://github.com/apache/spark/commit/da33acb8b681eca5e787d546fe922af76a151398. But this seems to be present in your branch. So may be I will have to dig deeper. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
