[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-56002947 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20529/consoleFull) for PR 2426 at commit [`a306020`](https://github.com/apache/spark/commit/a3060209cff765aa6ddf3be6a811ff3ee026a152). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-56008457 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20529/consoleFull) for PR 2426 at commit [`a306020`](https://github.com/apache/spark/commit/a3060209cff765aa6ddf3be6a811ff3ee026a152). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-56086638 This seems fine to me. For very common file editors seems okay to support them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
GitHub user sarutak opened a pull request: https://github.com/apache/spark/pull/2426 [SPARK-3566] [BUILD] .gitignore and .rat-excludes should consider cmd file and Emacs' backup files You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarutak/spark emacs-metafiles-ignore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2426.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2426 commit 8cade06dce9ea0ed09c47c01e31efa9e92312fcb Author: Kousuke Saruta saru...@oss.nttdata.co.jp Date: 2014-09-16T00:40:29Z Modified .gitignore to ignore emacs lock file and backup file commit 897da6321001bc3f9344ee0b501628d5c579d28a Author: Kousuke Saruta saru...@oss.nttdata.co.jp Date: 2014-09-17T08:12:51Z Merge branch 'master' of git://git.apache.org/spark into emacs-metafiles-ignore commit 6a0a5eb6a352009dd8c6b902a5253b8846b1bffc Author: Kousuke Saruta saru...@oss.nttdata.co.jp Date: 2014-09-17T08:22:28Z Added cmd file entry to .rat-excludes and .gitignore --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55864329 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20458/consoleFull) for PR 2426 at commit [`6a0a5eb`](https://github.com/apache/spark/commit/6a0a5eb6a352009dd8c6b902a5253b8846b1bffc). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55868873 You can have global gitignore. https://help.github.com/articles/ignoring-files. I am not sure how many editors and such we are going to support. Mind closing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55869359 @ScrapCodes Thanks for your comment. Vim/vi and Emacs is the most popular editors and current .gitignore considers vim's swp file so Emacs should be considered. Also, this PR includes the modification for Windows batch file so I cannot close this PR, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55869795 There is nothing like spark-env.cmd in the code base ? + Emacs is my editor of choice too and I add those excludes in gitignore global simply because I can not go and update gitignore on every open source project I work on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55870586 Current code base doesn't include spark-env.sh but user can create and used by spark-class2.cmd, run-examples2.cmd, compute-classpath.cmd and pyspark2.cmd. And if applying your logic, the entry for swp should be removed from .gitignore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55876167 **[Tests timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20458/consoleFull)** after a configured wait of `120m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55941688 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55942151 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20476/consoleFull) for PR 2426 at commit [`6a0a5eb`](https://github.com/apache/spark/commit/6a0a5eb6a352009dd8c6b902a5253b8846b1bffc). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3566] [BUILD] .gitignore and .rat-exclu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2426#issuecomment-55951349 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20476/consoleFull) for PR 2426 at commit [`6a0a5eb`](https://github.com/apache/spark/commit/6a0a5eb6a352009dd8c6b902a5253b8846b1bffc). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` class ArrayConstructor extends net.razorvine.pickle.objects.ArrayConstructor ` * `class NonASCIICharacterChecker extends ScalariformChecker ` * `class RatingDeserializer(FramedSerializer):` * `class SCCallSiteSync(object):` * ` class Encoder[T : NativeType](columnType: NativeColumnType[T]) extends compression.Encoder[T] ` * ` class Encoder[T : NativeType](columnType: NativeColumnType[T]) extends compression.Encoder[T] ` * ` class Encoder[T : NativeType](columnType: NativeColumnType[T]) extends compression.Encoder[T] ` * ` class Encoder extends compression.Encoder[IntegerType.type] ` * ` class Decoder(buffer: ByteBuffer, columnType: NativeColumnType[IntegerType.type])` * ` class Encoder extends compression.Encoder[LongType.type] ` * ` class Decoder(buffer: ByteBuffer, columnType: NativeColumnType[LongType.type])` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
