[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2611#issuecomment-57432064 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2611#discussion_r18267520
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1470,6 +1472,7 @@ private[spark] object Utils extends Logging {
return true
}
isBindCollision(e.getCause)
+ case e: MultiException = e.getThrowables.map(ex =
isBindCollision(ex)).reduceLeft(_ || _)
--- End diff --
I think you can just write `e.getThrowables.exists(isBindCollision)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/2611#discussion_r18268153
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1470,6 +1472,7 @@ private[spark] object Utils extends Logging {
return true
}
isBindCollision(e.getCause)
+ case e: MultiException = e.getThrowables.map(ex =
isBindCollision(ex)).reduceLeft(_ || _)
--- End diff --
yes, thanks, more cleanly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2611#issuecomment-57488591 Jenkins, test this please. LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2611#issuecomment-57490077 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21123/consoleFull) for PR 2611 at commit [`984cb12`](https://github.com/apache/spark/commit/984cb12ad756b4b6223a2c54335f214f3153814a). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2611#issuecomment-57501261 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21123/consoleFull) for PR 2611 at commit [`984cb12`](https://github.com/apache/spark/commit/984cb12ad756b4b6223a2c54335f214f3153814a). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2611#issuecomment-57501275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21123/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2611#discussion_r18299900
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -23,6 +23,8 @@ import java.nio.ByteBuffer
import java.util.{Properties, Locale, Random, UUID}
import java.util.concurrent.{ThreadFactory, ConcurrentHashMap, Executors,
ThreadPoolExecutor}
+import org.eclipse.jetty.util.MultiException
--- End diff --
too late (already merged) but this should be grouped with the other imports
below :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3756] [Core]check exception is caused b...
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/2611#discussion_r18313801
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -23,6 +23,8 @@ import java.nio.ByteBuffer
import java.util.{Properties, Locale, Random, UUID}
import java.util.concurrent.{ThreadFactory, ConcurrentHashMap, Executors,
ThreadPoolExecutor}
+import org.eclipse.jetty.util.MultiException
--- End diff --
very sorry for this, should i make a PR to fix this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
