[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread scwf
Github user scwf commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62110929
  
@liancheng, you need rebase this:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread liancheng
Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62139172
  
@scwf Thanks for reminding, rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62140381
  
  [Test build #23053 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23053/consoleFull)
 for   PR 3105 at commit 
[`d9585e1`](https://github.com/apache/spark/commit/d9585e1db73798b881f1908e784c6fffd8ff9446).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62156413
  
  [Test build #23053 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23053/consoleFull)
 for   PR 3105 at commit 
[`d9585e1`](https://github.com/apache/spark/commit/d9585e1db73798b881f1908e784c6fffd8ff9446).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62156422
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23053/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread scwf
Github user scwf commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62198555
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread marmbrus
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62201267
  
Thanks!  Merged to master and 1.2.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/3105


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-07 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-62220207
  
[Yay, this fixed the master Maven YARN 
build!](https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=centos/871/changes)


![image](https://cloud.githubusercontent.com/assets/50748/4960839/a0fdd2ca-66c7-11e4-8e5f-a5d8411fcda2.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-04 Thread liancheng
GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/3105

[SPARK-4225][SQL] Resorts to SparkContext.version to inspect Spark version

This PR resorts to `SparkContext.version` rather than META-INF/MANIFEST.MF 
in the assembly jar to inspect Spark version. Currently, when built with Maven, 
the MANIFEST.MF file in the assembly jar is incorrectly replaced by Guava 15.0 
MANIFEST.MF, probably because of the assembly/shading tricks.

Another related PR is #3103, which tries to fix the MANIFEST issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark spark-4225

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/3105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3105


commit 9ac61df93338ea739524d8f97db4ed0097f40b5b
Author: Cheng Lian l...@databricks.com
Date:   2014-11-05T05:49:42Z

Resorts to SparkContext.version to inspect Spark version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-04 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-61763527
  
  [Test build #22917 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22917/consoleFull)
 for   PR 3105 at commit 
[`9ac61df`](https://github.com/apache/spark/commit/9ac61df93338ea739524d8f97db4ed0097f40b5b).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-04 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-61770778
  
  [Test build #22917 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22917/consoleFull)
 for   PR 3105 at commit 
[`9ac61df`](https://github.com/apache/spark/commit/9ac61df93338ea739524d8f97db4ed0097f40b5b).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4225][SQL] Resorts to SparkContext.vers...

2014-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3105#issuecomment-61770780
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22917/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org