[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-96770116 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-96772334 Mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-92997220 @haitaoyao are you able to address the comments? If not, can we close this issue for now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3205#discussion_r25329334
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -108,13 +108,12 @@ private[spark] class ExecutorRunner(
}
/** Replace variables such as {{EXECUTOR_ID}} and {{CORES}} in a command
argument passed to us */
- def substituteVariables(argument: String): String = argument match {
--- End diff --
Of course, I don't mean you would have substitutions for values that don't
exist. It would be different between the two. The driver only supports two
substitutions now. I suppose I mean I like that you improved the logic to allow
substituting these placeholders *within* arguments. That would be nice to have
both places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3205#discussion_r25281949
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -108,13 +108,12 @@ private[spark] class ExecutorRunner(
}
/** Replace variables such as {{EXECUTOR_ID}} and {{CORES}} in a command
argument passed to us */
- def substituteVariables(argument: String): String = argument match {
--- End diff --
@haitaoyao would you mind addressing these comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75902600 [Test build #27933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27933/consoleFull) for PR 3205 at commit [`1a103c9`](https://github.com/apache/spark/commit/1a103c9a15ba95d3bd1537040829ec6e8c8acd68). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75896840 [Test build #27933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27933/consoleFull) for PR 3205 at commit [`1a103c9`](https://github.com/apache/spark/commit/1a103c9a15ba95d3bd1537040829ec6e8c8acd68). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user haitaoyao commented on a diff in the pull request:
https://github.com/apache/spark/pull/3205#discussion_r25314648
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -108,13 +108,12 @@ private[spark] class ExecutorRunner(
}
/** Replace variables such as {{EXECUTOR_ID}} and {{CORES}} in a command
argument passed to us */
- def substituteVariables(argument: String): String = argument match {
--- End diff --
but in the ``` `DriverRunner ``` there's no values for executor_id so the
code gonna be very tricky.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75902603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27933/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75564995 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75565369 [Test build #27852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27852/consoleFull) for PR 3205 at commit [`9f8db81`](https://github.com/apache/spark/commit/9f8db81cef7287a92b9752f2c09c01b3ddf0d8ac). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75581446 [Test build #27852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27852/consoleFull) for PR 3205 at commit [`9f8db81`](https://github.com/apache/spark/commit/9f8db81cef7287a92b9752f2c09c01b3ddf0d8ac). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75581461 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27852/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3205#issuecomment-75152856 Jenkins this is ok to test. @haitaoyao this looks like a good feature to have. The PR is somewhat old at this point and I think there may be some updates you'll need to make after you rebase to master. Once you do that @srowen and I will take a closer look again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4340] [Core] add java opts argument sub...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3205#discussion_r24257335
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -108,13 +108,12 @@ private[spark] class ExecutorRunner(
}
/** Replace variables such as {{EXECUTOR_ID}} and {{CORES}} in a command
argument passed to us */
- def substituteVariables(argument: String): String = argument match {
--- End diff --
Nevermind, I see that the original purpose of the method was to replace
entire tokens, not tokens within argument strings. And I see why you need it to
now replace tokens within strings.
It sounds like the behavior changes is OK, since I do not expect that these
`{{TOKEN}}`s appear anywhere in the command line arguments except where they
are supposed to be replaced. This change affects not just JVM options but all
command line options.
I like this change, with two small additions. There is a similar method in
`DriverRunner`. Although we're not considering replacement within driver args
now, it might be good to modify that method too for consistency along the same
lines, to avoid surprises.
A brief test of the new behavior, to go along with the existing unit test,
would be good too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
