[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64938599 LGTM, so I'm going to merge this into `master` and the maintenance branches. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64738171 @JoshRosen @srowen Any other comments? Is this ok to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/3449 [SPARK-4597] Use proper exception and reset variable `File.exists()` and `File.mkdirs()` only throw `SecurityException` instead of `IOException`. Then, when an exception is thrown, `dir` should be reset too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/viirya/spark-1 fix_createtempdir Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3449.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3449 commit 36cacbd1f2f5cfa4f2cb0814650ba439e2cff3f3 Author: Liang-Chi Hsieh vii...@gmail.com Date: 2014-11-25T08:12:54Z Use proper exception and reset variable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64324372 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64324781 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64325487 [Test build #23831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23831/consoleFull) for PR 3449 at commit [`36cacbd`](https://github.com/apache/spark/commit/36cacbd1f2f5cfa4f2cb0814650ba439e2cff3f3). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3449#discussion_r20849000
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -262,7 +262,7 @@ private[spark] object Utils extends Logging {
if (dir.exists() || !dir.mkdirs()) {
dir = null
}
- } catch { case e: IOException = ; }
+ } catch { case e: SecurityException = dir = null; }
--- End diff --
It looks like these two methods can't throw `IOException` after all, is
that the gist of it? `mkdirs` just returns `false` if it fails, hm.
https://docs.oracle.com/javase/7/docs/api/java/io/File.html#mkdirs()
`dir = null` is a good bug fix. I might have changed this to not even
assign `dir` and hold the new `File` in a temp variable until the checks
succeeded. This looks equivalent though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/3449#discussion_r20849117
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -262,7 +262,7 @@ private[spark] object Utils extends Logging {
if (dir.exists() || !dir.mkdirs()) {
dir = null
}
- } catch { case e: IOException = ; }
+ } catch { case e: SecurityException = dir = null; }
--- End diff --
Yes. The only exception they would throw is `SecurityException`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64344035 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23831/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4597] Use proper exception and reset va...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3449#issuecomment-64344002 [Test build #23831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23831/consoleFull) for PR 3449 at commit [`36cacbd`](https://github.com/apache/spark/commit/36cacbd1f2f5cfa4f2cb0814650ba439e2cff3f3). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
