[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user zuxqoj commented on a diff in the pull request: https://github.com/apache/spark/pull/3590#discussion_r25243866 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend( (--queue, SPARK_YARN_QUEUE, spark.yarn.queue), (--name, SPARK_YARN_APP_NAME, spark.app.name) ) +// Warn against the following deprecated environment variables: env var - suggestion +val deprecatedEnvVars = Map( + SPARK_MASTER_MEMORY - SPARK_DRIVER_MEMORY or --driver-memory through spark-submit, + SPARK_WORKER_INSTANCES - SPARK_WORKER_INSTANCES or --num-executors through spark-submit, + SPARK_WORKER_MEMORY - SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit, + SPARK_WORKER_CORES - SPARK_EXECUTOR_CORES or --executor-cores through spark-submit) +// Do the same for deprecated properties: property - suggestion +val deprecatedProps = Map(spark.master.memory - --driver-memory through spark-submit) --- End diff -- @andrewor14 In SPARK-1953 properties related to driver memory were removed form yarn-client mode. SPARK_MASTER_MEMORY and spark.master.memory are related to driver memory, so they should also be removed. I have created jira for it https://issues.apache.org/jira/browse/SPARK-5951 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3590#discussion_r25275869 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend( (--queue, SPARK_YARN_QUEUE, spark.yarn.queue), (--name, SPARK_YARN_APP_NAME, spark.app.name) ) +// Warn against the following deprecated environment variables: env var - suggestion +val deprecatedEnvVars = Map( + SPARK_MASTER_MEMORY - SPARK_DRIVER_MEMORY or --driver-memory through spark-submit, + SPARK_WORKER_INSTANCES - SPARK_WORKER_INSTANCES or --num-executors through spark-submit, + SPARK_WORKER_MEMORY - SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit, + SPARK_WORKER_CORES - SPARK_EXECUTOR_CORES or --executor-cores through spark-submit) +// Do the same for deprecated properties: property - suggestion +val deprecatedProps = Map(spark.master.memory - --driver-memory through spark-submit) --- End diff -- SPARK-1953 did not remove any driver memory setting from yarn-client mode; it just introduced new ones for the AM, so it's unrelated to the discussion here. I do agree that we should remove these configs for 1.4, but the reason has nothing to do with the ApplicationMaster. Thanks for filing that JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user zuxqoj commented on a diff in the pull request: https://github.com/apache/spark/pull/3590#discussion_r25155375 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend( (--queue, SPARK_YARN_QUEUE, spark.yarn.queue), (--name, SPARK_YARN_APP_NAME, spark.app.name) ) +// Warn against the following deprecated environment variables: env var - suggestion +val deprecatedEnvVars = Map( + SPARK_MASTER_MEMORY - SPARK_DRIVER_MEMORY or --driver-memory through spark-submit, + SPARK_WORKER_INSTANCES - SPARK_WORKER_INSTANCES or --num-executors through spark-submit, + SPARK_WORKER_MEMORY - SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit, + SPARK_WORKER_CORES - SPARK_EXECUTOR_CORES or --executor-cores through spark-submit) +// Do the same for deprecated properties: property - suggestion +val deprecatedProps = Map(spark.master.memory - --driver-memory through spark-submit) --- End diff -- SPARK_MASTER_MEMORY and spark.master.memory are not applicable in yarn-client mode should be removed, please refer SPARK-1953 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3590#discussion_r25214428 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend( (--queue, SPARK_YARN_QUEUE, spark.yarn.queue), (--name, SPARK_YARN_APP_NAME, spark.app.name) ) +// Warn against the following deprecated environment variables: env var - suggestion +val deprecatedEnvVars = Map( + SPARK_MASTER_MEMORY - SPARK_DRIVER_MEMORY or --driver-memory through spark-submit, + SPARK_WORKER_INSTANCES - SPARK_WORKER_INSTANCES or --num-executors through spark-submit, + SPARK_WORKER_MEMORY - SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit, + SPARK_WORKER_CORES - SPARK_EXECUTOR_CORES or --executor-cores through spark-submit) +// Do the same for deprecated properties: property - suggestion +val deprecatedProps = Map(spark.master.memory - --driver-memory through spark-submit) --- End diff -- @zuxqoj the master here doesn't actually refer to the ApplicationMaster, but the driver, so SPARK-1953 is actually unrelated. It's really the result of bad naming that we inherited from a long time ago, and this is why we're deprecating it. I agree we should just remove it for 1.4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/3590#issuecomment-67955599 +1 looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3590#issuecomment-68005737 LGTM, too, so I'm going to merge this into `master` (1.3.0) and `branch-1.2` (1.2.1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3590#issuecomment-67898488 Any other comments @tgravescs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3590#issuecomment-66393724 [Test build #24287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24287/consoleFull) for PR 3590 at commit [`36e0753`](https://github.com/apache/spark/commit/36e075348b9dcbbea74dcff3d63f94d1f29f2db7). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3590#issuecomment-66399346 [Test build #24287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24287/consoleFull) for PR 3590 at commit [`36e0753`](https://github.com/apache/spark/commit/36e075348b9dcbbea74dcff3d63f94d1f29f2db7). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3590#issuecomment-66399349 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24287/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/3590#discussion_r21311665 --- Diff: yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend( (--queue, SPARK_YARN_QUEUE, spark.yarn.queue), (--name, SPARK_YARN_APP_NAME, spark.app.name) ) +// Warn against the following deprecated environment variables: env var - suggestion +val deprecatedEnvVars = Map( + SPARK_MASTER_MEMORY - SPARK_DRIVER_MEMORY or --driver-memory through spark-submit, + SPARK_WORKER_INSTANCES - SPARK_WORKER_INSTANCES or --num-executors through spark-submit, + SPARK_WORKER_MEMORY - SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit, + SPARK_WORKER_CORES - SPARK_EXECUTOR_CORES or --executor-cores through spark-submit) --- End diff -- aren't essentially all of the env variables deprecated? I know we have warnings on some throughout the code but haven't checked for all of them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3590#discussion_r21351573 --- Diff: yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend( (--queue, SPARK_YARN_QUEUE, spark.yarn.queue), (--name, SPARK_YARN_APP_NAME, spark.app.name) ) +// Warn against the following deprecated environment variables: env var - suggestion +val deprecatedEnvVars = Map( + SPARK_MASTER_MEMORY - SPARK_DRIVER_MEMORY or --driver-memory through spark-submit, + SPARK_WORKER_INSTANCES - SPARK_WORKER_INSTANCES or --num-executors through spark-submit, + SPARK_WORKER_MEMORY - SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit, + SPARK_WORKER_CORES - SPARK_EXECUTOR_CORES or --executor-cores through spark-submit) --- End diff -- We actually still document the rest of them in `spark-env.sh` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
