[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68734038 @JoshRosen Then is it ok? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68767569 LGTM, so I'll pull this into `master` (1.3.0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3875 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68594892 [Test build #25010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25010/consoleFull) for PR 3875 at commit [`1503487`](https://github.com/apache/spark/commit/1503487f12d77a3d1fe6c2aafde12c7de4d024d2). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68594844 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68597246 [Test build #25010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25010/consoleFull) for PR 3875 at commit [`1503487`](https://github.com/apache/spark/commit/1503487f12d77a3d1fe6c2aafde12c7de4d024d2). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68597278 @JoshRosen I also think it's better to use string interpolation. In this class some places use interpolation while others don't. So I changed those who don't to keep consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68597248 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25010/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68549854 Matches error message from 20 lines up, so LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/spark/pull/3875 [SPARK-5057]Add more details in log when using actor to get infos https://issues.apache.org/jira/browse/SPARK-5057 You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangTaoTheTonic/spark SPARK-5057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3875.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3875 commit 706c8a7d02a07bfc6b096221777f44eabc36467b Author: WangTaoTheTonic barneystin...@aliyun.com Date: 2015-01-02T10:20:41Z log more messages --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68518118 [Test build #24993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24993/consoleFull) for PR 3875 at commit [`706c8a7`](https://github.com/apache/spark/commit/706c8a7d02a07bfc6b096221777f44eabc36467b). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-5057]Add more details in log when using...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3875#issuecomment-68581252 I suppose it'd be nice to use string interpolation here, but I guess the old code didn't use it either, so this matches the surrounding style --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
